273226 - Location bar dropdown menu detached

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Gids Goldberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041204 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041204 Firefox/1.0+

The location bar dropdown is detatched from the location bar and lacks a
dropdown shadow. Seen on XP Classic and XP Luna 

Reproducible: Always
Steps to Reproduce:
1.Click the location bar dropdown arrow

Actual Results:  
There's a gap between the dropdown menu and the location bar

Expected Results:  
No gap between them, the location bar should have a drop shadow

Comment 1

[Gids Goldberg]

Attachment: location bar dropdown with gap

Comment 2

[Phil Ringnalda (:philor)]

*** Bug 273328 has been marked as a duplicate of this bug. ***

Comment 3

[Steffen Wilberg]

Affects Linux (GTK2) as well.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This first appeared on the 11-24 Trunk build. I'm not so sure this was caused by
the aviary landing.

Comment 5

[Phil Ringnalda (:philor)]

Wups, my bad. In theory I would have checked my pre-landing build before
claiming it was, but in fact since that shows it, I must not have.

Comment 6

[Martijn Wargers (dead)]

It can't see the bug in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041123
Firefox/0.9.1+ 8:16am
But I can see the bug in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041124
Firefox/0.9.1+ 8:12am

I think the fix for bug 268576 could have caused this regression.

It looks like the gap is just as high as the url bar is offset from the top of
the box it is in.
It is indeed also a bit to the right, a few pixels.

Mozilla doesn't suffer from this bug. It has a different way to calculate where
the autocomplete popup should be. 

Firefox XUL autocomplete textboxes are opened from textboxes with this method:
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/autocomplete.xml#302
That is calling this:
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/autocomplete.xml#502

Comment 7

[amano]

That seems to be a good guess. I added Boris Zbarsky to the CC list, since he
coded the stuff in bug 268576 ;)

Comment 8

[Boris Zbarsky [:bzbarsky]]

I bet the patch in bug 271891 fixes this...  Could someone check?

Comment 9

[Steffen Wilberg]

The patch in bug 271891 fixes this indeed.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 271891