271891 - [FIX]Cannot drop to subfolder of the personal toolbar's folder

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041123
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041123

I cannot drop bookmark item to subfolder on personal toolbar's folder.
It is not reproduced on 2004112306.
After 20041124xx builds are bad.

Reproducible: Always
Steps to Reproduce:
1. Create folder 'A' on personal toolbar
2. Create folder 'B' in folder 'A'
3. Drag the bookmark item, and drop to 'B'

Actual Results:  
The folder 'B' is not opened, and feedback line is shown above and bottom the
folder. not hilight the folder.

Expected Results:  
The folder 'B' should be opened, and we should be able to drop to the folder.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-11-23&maxdate=2004-11-24+08%3A00%3A00&cvsroot=%2Fcvsroot

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Is this regression caused by bug 268576?

Comment 2

[Boris Zbarsky [:bzbarsky]]

This worksforme in a Linux debug build pulled from CVS at "Mon Nov 29 16:02:35
CST 2004" (as well as another build I have from Nov 25).

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I can reproduce with 2004113004/WinXP.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Perhaps I am misunderstanding the steps to reproduce?

I create a folder "A" on the personal toolbar and a folder "B" inside it.  Then
I grab the url in the urlbar, drag it to "A" and don't let go.  After half a
second or so "A" opens and I can drag down to "B", which  opens too (it's empty,
so shows an empty popup).  If I release over "B", the bookmark is dropped into "B".

I just retested this with a 2004-11-30-08 mozilla.org nightly (still on Linux).
 It works the same exact way as a 2004-11-22-08 build.

Perhaps this is a Windows-only issue?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sorry, my steps are wrong.

1. Create folder 'A' on personal toolbar
2. Create folder 'B' in folder 'A'
3. Create folder 'C' bottom 'B'(in 'A')
3. Drag the bookmark item, and drop to 'C'

I can drop 'B', but cannot drop 'C'.

Please re-test on Linux.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Personal Toolbar 'A'
                  +-'B'      <- B is opened and can be dropped
                  +-'C'      <- C is not opened and can not be dropped

Comment 7

[Sven Grull]

Is this the same problem that occurs in bug 276126 ?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 276126 has been marked as a duplicate of this bug. ***

Comment 9

[Sven Grull]

Bug 276126 was a Firefox bug. If bug 276126 ist duped against this one, should
product not be changed to core? 
In addition this seems not to be only a problem for the personal toolbar. As
well dragging an url via the bookmark menu item does not open the sub-folders.

Comment 10

[daneel]

This is a problem for me and others I have installed FF for. I use 20041228
while others use a mix of nightlies after 20041228. All plugins had been
disabled/removed with no success.

Comment 11

[daneel]

Using XP sp1.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Nakano-san, thank you for the steps in comment 5!  With those, I can indeed
reproduce the bug, and you're correct that it's a regression from bug 268576. 
I'm sorry it took me so long to respond to that comment; I was out of town and
had very spotty computer access...

David, the patch is pretty simple.  We were double-counting the offset of
mRect, since it was getting included both in the offset from the view and in
ourRect.  As a result the screen coordinates this method returned were off by
mRect.TopLeft().

Comment 13

[Jerry Baker]

A similar issue is that you cannot drag and place a bookmark as the last item in
a list just as you cannot drag into a folder that is last in a list.

Comment 14

[Boris Zbarsky [:bzbarsky]]

That's the same issue.

Comment 15

[Peter Lairo]

Bug 276017, bug 273466 and bug 271891 are essentially all the same bug. Could we
just pick one and dupe the others to get some focus? This is an important bug.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Peter, please read bugs before making inane comments like that.  For example,
this bug and bug 273466 are very clearly NOT the same bug.

Comment 17

[Dan Mellem]

The bugs are similar, but may or may not be the same
Bug 276017 is about dropping a bookmark in a folder in the Bookmarks folder
bug 273466 is about dropping a bookmark in the bookmark sidebar
bug 271891 (this one) is about dropping a bookmark in a personal toolbar subfolder

Comment 18

[Peter Lairo]

(In reply to comment #16)
> Peter, please read bugs before making inane comments like that.  For example,
> this bug and bug 273466 are very clearly NOT the same bug.

Boris: Please try to get *something* positive out of a comment before making
accusations like that. I did read the bugs. I mainly wanted to point out the
*existence* of the other very similar bugs ("dragging URLs into bookmarks") that
*might* have the same or a similar solution, in *case* some of the developers
were not aware of the other bugs. Sorry for not being more clear (s/same/similar).

Comment 19

[Boris Zbarsky [:bzbarsky]]

Peter, there is no "the developers."  For example, I really could not care less
about bugs that are specific to the bookmarks front-end implementation in
Firefox.  I do care about core bugs like this one.  I'm sure the Firefox
developers feel the same way, in reverse.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 21

[OstGote!]

Another bug seems to be fixed by this (was perhaps a dupe): Bug 277070.

Comment 22

[Hermann Schwab]

*** Bug 277070 has been marked as a duplicate of this bug. ***

Comment 23

[HJ]

*** Bug 276017 has been marked as a duplicate of this bug. ***

Comment 24

[Boris Zbarsky [:bzbarsky]]

*** Bug 282668 has been marked as a duplicate of this bug. ***

Comment 25

[Pete Hammer]

For lack of any drag/drop into subfolder functionality in OSX, I opened a new
bug: bug 299185

"Toolbar folders don't open when a url is dragged onto them - prevents placement
of bookmarks in subfolders or where desired in order in folders"

Comment 26

[Frank Wein [:mcsmurf]]

*** Bug 314981 has been marked as a duplicate of this bug. ***