27348 - Dragging off button doesn't restore original appearance

Status: RESOLVED FIXED

(Core :: XUL, defect, P4)

Description

[Matthew T (active 1999-2002)]

Build: 2000021014, Win98

To reproduce:
* Start Mozilla.

Then either:
* Click on an enabled toolbar button, and keep the mouse button down.
* Drag the mouse pointer off the button.

Or:
* Open a dialog, such as the Prefs dialog or the Wallet Contents dialog.
* Click on an enabled button, and keep the mouse button down.
* Drag the mouse pointer off the button.

What should happen:
* The button should be restored to its original appearance (or, at least, the
  appearance it had when moused over) and position.

What actually happens:
* The button persists in its mouse-downed appearance. This gives the incorrect
  impression that the button action can not be cancelled by dragging off the
  button.

Comment 1

[Peter Trudelle]

reassigning to evaughan as p4 for m16.  

Comment 2

[Ronald van Kuijk]

This happens with all widgets but the toolbar works for me. 

Attachment:
Two things happen here.

If the mouse is moved on a link there is an mouseover event. When the button is 
pressed a mousedown event occurs, but when the mouse is moved off the link with 
the button down (a drag?) there is a mouseout event in mozilla, but not in 4xp.

If the button is released outside the 'canvas' of the document (whether this is 
a xul document, or a dialogbox or whatever) the buttonup does not get send to 
the target that originally got the mousedown event) If it stay's within the xul 
document it does work.

This problem only occurs within XUL (afaik, but not in the toolbar's and these 
XUL to aren't they?) because the plain html attachment does not show these 
problems

(I'd love to help with these event problems but cannot get a grip on the 
internal event architecture of mozilla. Is there some more info somewhere?)

Comment 3

[Ronald van Kuijk]

This happens with all widgets but the toolbar works for me. 

Attachment:
Two things happen here.

If the mouse is moved on a link there is an mouseover event. When the button is 
pressed a mousedown event occurs, but when the mouse is moved off the link with 
the button down (a drag?) there is a mouseout event in mozilla, but not in 4xp.

If the button is released outside the 'canvas' of the document (whether this is 
a xul document, or a dialogbox or whatever) the buttonup does not get send to 
the target that originally got the mousedown event) If it stay's within the xul 
document it does work.

This problem only occurs within XUL (afaik, but not in the toolbar's and these 
XUL to aren't they?) because the plain html attachment does not show these 
problems

(I'd love to help with these event problems but cannot get a grip on the 
internal event architecture of mozilla. Is there some more info somewhere?)

Comment 4

[Ronald van Kuijk]

Attachment: mouseout / dragged testcase

Comment 5

[Matthew T (active 1999-2002)]

*** Bug 30384 has been marked as a duplicate of this bug. ***

Comment 6

[Matthew T (active 1999-2002)]

This looks fixed now, on MacOS build 2000031108. Can someone confirm on all 
platforms?

Comment 7

[Paul MacQuiddy]

maybe john will be kind enough to check this out

Comment 8

[John Morrison]

Pinkerton fixed this for buttons on Mac and Windows (see bug #30911). 
However, linux is not fixed (but native widgets on linux have a dual behaviour
in this regard anyways -- button becomes undepressed, but a focus outline 
stays on no matter what (also true of motif)). 

I believe that despite the Summary, bug #30384 was intended to cover the 
behaviour of all widgets (radio, checkbox, button, etc.). I'm going to reopen
30384 and make sure that is the case. 

Comment 9

[Eric Vaughan]

fixed

Comment 10

[Matthew T (active 1999-2002)]

Reopening. Build 2000032308 trunk, MacOS 8.6.

If I follow the toolbar button example as described in the original report, the 
original graphic is restored, but about 4 pixels southeast of where it should be. 
The edges go blurry, because part of the graphic in the original position is left 
behind. After the mouse button is released, the toolbar button only returns to 
its proper place when moused over again.

Comment 11

[Matthew T (active 1999-2002)]

Ok, the button displacement issue is covered by bug 20027. Returning this to 
FIXED.