274010 - "Restore Default Set" of a customize tool bar works only a part.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Hiro]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.8a6) Gecko/20041209 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.8a6) Gecko/20041209 Firefox/1.0+

If "Restore Default Set" of a customize tool bar is pushed in Firefox, things
other than an icon set will also restore.
(For example, icon size etc.)

But they are not restored in thunderbird.


Reproducible: Always
Steps to Reproduce:
1."Use Small Icons" and list of "Show" are set up by the customize toolbar.
2.push "OK"
3.A customize toolbar is opened again.
4.push "Restore Default Set"

Actual Results:  
Only a default icon set is restored.

Expected Results:  
"Use Small Icons" and list of "Show" is also restored.

Windows XP Pro SP1
Thunderbird 1.0 Release version

Comment 1

[Hideo Oshima]

I can reproduce too.

version 1.0+ (20050428)

Comment 2

[Hideo Oshima]

2005102307-trunk/Linux build still has this problem.

Comment 3

[Hiro]

The same correction as bug-org255572 is necessary. 

Comment 4

[Hiro]

Attachment: quick port patch

The patch of bug255572 is changed and the mode of the default toolbar has been changed for Thunderbird.

Comment 5

[Scott MacGregor]

Comment on attachment 244795 [details] [diff] [review]
quick port patch

adding Phil as a reviewer since he's been looking at the toolbar code.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 244795 [details] [diff] [review]
quick port patch

>-const kWindowWidth = 600;
>+const kWindowWidth = 635;

That's unrelated and not needed (it fixed a problem with the width of the "Add new toolbar" button that Thunderbird doesn't have, in the old sheet implementation).

r=philringnalda without the width change

Comment 7

[Hiro]

Attachment: update patch

update comment#6

Scott-san, Please SR.

Comment 8

[Scott MacGregor]

Comment on attachment 244891 [details] [diff] [review]
update patch

thank you for porting this fix!

Comment 9

[Hiro]

Thanks r+sr.

Phil-san,
Please do the check-in of this patch. 

Comment 10

[Scott MacGregor]

gavin might be able to help you check this in. 

Comment 11

[Phil Ringnalda (:philor)]

If not, I should be home from work early enough for tree-watching tonight, as long as the tree is willing to cooperate and be open when I want it.

Comment 12

[Phil Ringnalda (:philor)]

Trunk: mail/base/content/customizeToolbar.js 1.9
Branch:  mail/base/content/customizeToolbar.js 1.7.4.2

Comment 13

[Carsten Book [:Tomcat]]

verified fixed for 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 ID:2007032620 - Restore Default Set is working fine.