274423 - Invalid column name error for search order from specific search

Status: RESOLVED DUPLICATE of bug 274640

(Bugzilla :: Bugzilla-General, defect)

Description

[Joshua Nixon]

On search for new bugs, bugzilla 2.19.1+ returns the following error:

The custom sort order specified in your cookie contains an invalid column name
relevance DESC LIMIT 200. The cookie has been cleared.

Comment 1

[Nick Barnes]

I can't reproduce this.  Can you describe the problem in more detail?

Comment 2

[Dave Miller [:justdave]]

It's reproducible, but I'm not sure how.  The error message tells them to mail
it to the admin, and I've had several mailed to me since we upgraded.  See bug
274640.

I'm not going to dupe the bug because we need to try to figure out why it's
happening to begin with.  The other bug is more "this needs to be dealt with in
a better way when it happens" thing.  This one can be for "let's find a way to
prevent this from happening."  If they wind up being easier to solve together we
can combine them at that point.

Comment 3

[Dave Miller [:justdave]]

OK, I found the cause of this...

The checkin from bug 237176 removed the following chunk of code from buglist.cgi:

-# Even more disgusting hack: if we are doing a full text search,
-# order by relevance instead of anything else, and limit to 200 results.
-if ($search->{'sorted_by_relevance'}) {
-    $db_order = $order = "relevance DESC LIMIT 200";
-    $vars->{'sorted_by_relevance'} = 1;
-}

Note that the code that *used* to be there added the "relevance DESC LIMIT 200"
to the sort order variable instead of tacking it directly onto the query itself
(which is what the current code does).  This would have resulted in a cookie
getting set with that as their sort order once the page is displayed.  When this
was removed, the checks to insure a valid sort order were also beefed up.  That
chunk no longer passes the test, because "LIMIT 200" isn't a legal part of the
sort order (and never was - that's a different portion of the SQL query).

So the people who are hitting this are people who have made use of the Specific
search prior to our upgrade, and are getting this on the first query they make
after using Bugzilla for the first time after the upgrade.

There is, then, nothing we can really do to prevent this from happening, and the
only thing we need to do is deal with it in a less threatening way.

*** This bug has been marked as a duplicate of 274640 ***

Comment 4

[Dave Miller [:justdave]]

actually, I'm putting this back on the regressions list to make it easier to
find because the summary is closer to what people will think of than the other bug.

Comment 5

[Dave Miller [:justdave]]

clearing target of DUPLICATE/WONTFIX/INVALID/WORKSFORME so they'll show up as
untriaged if they get reopened.