274802 - Save flags having the same name on product change

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Frédéric Buclin]

If two different flag types have the same name in two distinct products, moving
a bug from one product to the other should keep the corresponding flags.
Actually, all flags from flag types which are not in both products are removed.
This is a pain for example with all these review+/- superreview+/- approval+/-
flags which we certainly want to keep (as long as these flag type names exist in
both products).

This is suggested in bug 261995 comment 4 and responds to a real need, for
example bug 274704.

LpSolit: justdave, does it make sense to keep flags if they have the same name?
I would say yes!
justdave: LpSolit: Myk says so in his last comment of that bug
justdave: go find it, and if there isn't one, file it ;)

Comment 1

[Dave Miller [:justdave]]

I'll take this for 2.20, but not blocking release on it.

Comment 2

[Frédéric Buclin]

*** Bug 290755 has been marked as a duplicate of this bug. ***

Comment 3

[Frédéric Buclin]

Note to self: look at Bugzilla::Flag::process():

foreach my $flag_id (@$flag_ids) { clear($flag_id) }

and update flags.type_id for flags which still apply in the new product.

Comment 4

[Frédéric Buclin]

I won't have time to play with it before the 2.22 freeze

Comment 5

[Reed Loden [:reed]]

What's the status on this? This caused problems again today when moving devmo stuff to its new product. :/

Comment 6

[Frédéric Buclin]

(In reply to comment #5)
> What's the status on this? This caused problems again today when moving devmo
> stuff to its new product. :/
> 

This bug is high in my priority list, but bug 322285 has to land first (because it's higher in my priority list), and itself depends on bug 329537, which depends on mkanat. So pester mkanat to get bug 329537 fixed asap. :)

Comment 7

[timeless]

all of those dependencies are gone. we're still hoping to see this :)

Comment 8

[Frédéric Buclin]

(In reply to comment #7)
> all of those dependencies are gone. we're still hoping to see this :)
> 

This bug now depends on changes made in bug 174039 and bug 343810. They both should land very soon now (say in the next 10 days). I already started working on this bug today. I can probably have a patch within 2-3 weeks, in time for Bugzilla 3.0.

Comment 9

[Frédéric Buclin]

My patch is almost ready. I can attach it as soon as bug 343809 lands (I need its _validate() function). Waiting for myk and his review. :)

Comment 10

[Frédéric Buclin]

Attachment: patch, v1

Comment 11

[Frédéric Buclin]

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.143; previous revision: 1.142
done
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.75; previous revision: 1.74
done

Comment 12

[:Gavin Sharp [email: [e-mail]]]

*** Bug 362497 has been marked as a duplicate of this bug. ***

Comment 13

[Max Kanat-Alexander]

Added to the relnotes currently attached to bug 349423.