275923 - Receive Incompatible Extension when Using Special Category

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Fnord]

If I click on the "Popular", "Top Rated", or "New" I correctly get a list of
extenstions [probably "Editor's Pick" too, but it's empty right now]. But
clicking on any of the extensions gives an error:

"Incompatible Extension or Extension No Longer Available
The extension you requested is either incompatible with the application
selected, or the version of it is no longer available on Mozilla Update."

I can get to the extensions through the normal categories, though. Seems like
these 3 dynamic categories are forgetting what browser/OS I'm using.

It would also be nice if this error (when valid) was more specific. There should
be seperate errors for "the extension is there but is incompatible" and "the
extension is no longer available".

Comment 1

[Fnord]

*** Bug 275922 has been marked as a duplicate of this bug. ***

Comment 2

[kitchin]

Confirming, and here is the fix.
The page
https://addons.update.mozilla.org/extensions/showlist.php?application=firefox&version=1.0&os=Windows&category=Newest
has bad links like this one:
https://addons.update.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&category=Newest&numpg=10&id=418
which should be:
https://addons.update.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&numpg=10&id=418

Comment 3

[kitchin]

Possible fix for code:

File:
http://lxr.mozilla.org/mozilla/source/webtools/update/themes/showlist.php

Insert at Line 199 (before "// Modify List Form"): 
$uriparams_skip="category";

Insert at Line 454 (before "// Begin Code for Dynamic Navbars"):
$uriparams_skip="";

Comment 4

[kitchin]

Forget that last comment, sorry.
The fix has to be made to
http://lxr.mozilla.org/mozilla/source/webtools/update/themes/moreinfo.php
instead.  Otherwise, we lose category highlighting in the left menu.

Something like

if ($category=="Editors Pick" or $category=="Newest" or $category=="Popular" or
$category=="Top Rated") {
$category = "%";
}

after the line
 include"inc_sidebar.php";

Comment 5

[alanjstr]

Attachment: If the category is special, unset it

This is for exensions.	If this is right, I'll do themes.

Comment 6

[alanjstr]

Attachment: Patch for themes

Comment 7

[alanjstr]

Attachment: Ran amuck with whitespace fixes

Comment 8

[alanjstr]

Attachment: patch without whitespace differences

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 172071 [details] [diff] [review]
Ran amuck with whitespace fixes

sheesh

Looks ok though.