276812 - If you define a message filter with Message Filter window open, filter doesn't appear.

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[George Worley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041231
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20041231

When you define a message filter with the Message filter window open Message
Filter window doesn't show new filter unless you close Message Filter window and
then re-open or you change email servers then change back to the orignal.

Reproducible: Always

Steps to Reproduce:
1. Open Mail & Newsgoups.
2. Open Message Filter window.
3. Go back to back to Mail & Newsgroups window.
4. Define a Message Filter.
5. Go back to Message Filter window.

Actual Results:  
Message filter wasn't there.   Had to close and reopen message filter window to
see newly defined filter.

Expected Results:  
2 things should have happened.

1) Message Filter window should have come up on it's on.
2) Newly defined message filter should have appear

Comment 1

[Mark Banner (:standard8)]

Confirming bug and setting OS to all. I can reproduce on Mozilla/5.0 (X11; U;
Linux i686; en-US; rv:1.8a6) Gecko/20050103.

Errors produced on console as follows when OK of filter dialog is selected:
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "preselectedFolder is not defined" {file:
"chrome://messenger/content/mailWindowOverlay.js" line: 1404}]' when calling
method: [nsIController::doCommand]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://global/content/globalOverlay.js :: goDoCommand :: line 69"  data: yes]
************************************************************
An error occurred executing the cmd_createFilterFromMenu command
[Exception... "'[JavaScript Error: "preselectedFolder is not defined" {file:
"chrome://messenger/content/mailWindowOverlay.js" line: 1404}]' when calling
method: [nsIController::doCommand]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
chrome://global/content/globalOverlay.js :: goDoCommand :: line 69"  data: yes]

This may be a regression from the avairy to seamonkey port of bug 271696.

Comment 2

[Mark Banner (:standard8)]

Attachment: Patch to fix regression for Mailnews and TB

This patch adds the missing changes from preselectedFolder to folder for both
mailnews and TB. Going for r + sr at the same time as it's a simple fix.

Comment 3

[[e-mail]]

Comment on attachment 170141 [details] [diff] [review]
Patch to fix regression for Mailnews and TB

Oops - fallout from bug 271696 I see ;-)

Comment 4

[[e-mail]]

Fix checked in.

Comment 5

[Mark Banner (:standard8)]

*** Bug 277164 has been marked as a duplicate of this bug. ***