278621 - "sort by: calendar name" still sorts after date

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[mozillabugs]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20050111 Mozilla Sunbird/0.2RC2

having multiple calendar-files, sorting by calendar name does not work correctly:
i have three different calendars: a regular one, one for birthdays and one for
holidays. the holiday calendar contains all holidays from 2002 to 2007 (not as
reoccuring events but single events).
sorting by calendar names still sorts after date.

Reproducible: Always

Steps to Reproduce:
1. multiple calendars needed
2. display "calendar names"
3. click the column header to sort after calendar names

Comment 1

[mozillabugs]

bug appears ins sunbird 0.2RC2.

Comment 2

[gekacheka]

Attachment: unifinder.js patch: add calendar name clause to compareEvents (0.2 branch)

(patch -p 2 -i file.patch)

Problem is compareEvents function does not have a clause for calendar name.

This patch adds it.

Tested against 0.2 branch:  adding calendar name column and then clicking the
header does sort by that column.

Comment 3

[marin]

*** Bug 288441 has been marked as a duplicate of this bug. ***

Comment 4

[gekacheka]

Attachment: for sorting event list, add clause to compare by calendar name

(patch -l -p 2 -i file.patch)

Compares event.parent.name as strings.
Depends on bug 295164 to display name column.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 184285 [details] [diff] [review]
for sorting event list, add clause to compare by calendar name 

r=mvl

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 7

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!