279366 - "Options > Send a Copy" makes copy on SAVE; multiple saves results in multiple copies in the Drafts folder

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Klaus Johannes Rusch]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910

When setting a folder where mail should be stored using Options > Send a copy
to, a copy of the mail is stored in that folder not only when the message is
sent (once) but every time the message is saved/saved as draft.

A copy should only be placed when the mail is actually sent.

Reproducible: Always

Steps to Reproduce:
1. Compose
2. Options > Send a copy to > Select folder
3. Hit Ctrl-S, Ctrl-S, Ctrl-S => three copies of the mail have been saved in the
specified folder

Actual Results:  
Multiple copies of the mail in the designated folder

Expected Results:  
One copy of the mail in the designated folder after sending the mail only

Comment 1

[Mike Cowperthwaite]

(In reply to comment #0)
> Actual Results:  
> Multiple copies of the mail in the designated folder

I do not see this.  I see a single copy stored in the designated folder (and 
updated each time if edits are made between saves), but multiple copies being 
stored in the DRAFTS folder.  If the "Save a copy to" setting has not been made, 
then multiple saves overwrite the copy in Drafts.

However, I agree with reporter, the copy should not be saved at all until the 
message is sent.  Maybe these are separate bugs.

Moz 1.7.5, Moz 1.8b-0120, TB 1.0; Win2K.


Also (separate problem) -- if the original composition window is closed, and 
then a draft is edited, the Save A Copy setting is not restored.

Comment 2

[Nick Hemsley]

I can reproduce this bug on Firefox 1.5.0.3, windowsXP SP2.

I have been getting this problem since FF 1.5 (fairly sure).

Pasting is fine multiple times, but as soon as you try to copy twice, nothing gets pasted anymore.

Comment 3

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 4

[Klaus Johannes Rusch]

The problem still persists in the latest Seamonkey build

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4

Comment 5

[Wayne Mery (:wsmwk)]

Klaus, can you reproduce this also with thunderbird 2? (just as a test)
www.getthunderbird.com

Comment 6

[WADA:World Anti-bad-Duping Agency]

Wayne Mery, Bug 488075 is report for Tb trunk(Tb 3). Bug 488075 is DUP of this bug?

Comment 10

[Wayne Mery (:wsmwk)]

TCW can you reproduce?

Comment 11

[Arthur K. (he/him)]

(In reply to Wayne Mery (:wsmwk) from comment #10)

TCW can you reproduce?

Well, I'll be. Yup, I can sort of repro this but slightly in reverse order.

My STR:

1. Open Composer and type [e-mail] into the To: field
2. Now, click Options > Send A Copy To > pick some folder belonging to the same account that would be sending to [e-mail]
3. Hit Ctrl-S a few times

Actual Results:
A few copies get saved in the Drafts folder, not the folder chosen in Step 2. Only one copy gets saved in the folder from Step 2.

Expected Results:
Probably not the same as the Actual Results.

Comment 12

[Arthur K. (he/him)]

Oddly, nothing in Error Console.

Comment 13

[Arthur K. (he/him)]

This is odd too. I went to delete all the copies in Drafts and it nuked the copy in the folder from step 2. How do you like them apples?

Comment 14

[Arthur K. (he/him)]

Attachment: huh.png

What new he** is this? The folder that I used as a guinea pig has now change into a...drafts folder? In this image, the folder used to be below the Trash folder. Now it's icon is different and I can't move it or change it back? What do you think happened?

Comment 15

[Arthur K. (he/him)]

Attachment: huh.png

Comment 16

[Arthur K. (he/him)]

So after fiddling with this a bit, it now seems I can't make TB see this as a folder any longer. Even after deleting it via GMail's web UI and recreating it, TB recreates it as a Draft folder. This change seems permanent and on the TB side. =(

Functionally, it seems ok as I have filters set up to push mails into it every 8AM. So other than it taking on the icon of a draft folder, it still seems to be a folder. Or, Label, in GMail-speak.

Comment 17

[Arthur K. (he/him)]

I fixed my issue but this will likely bite someone else too so I am posting the solution / fix. After installing the Add-on, right-click the folder, choose Properties, click the Flags tab and uncheck the Drafts checkbox. Would be nice to have this flags tab (or something like it) handy for just this rare occasion.

I believe the effected folders have got a folder flag for drafts.

Please use this addon:

https://addons.thunderbird.net/en-us/thunderbird/addon/folderflags/

Comment 18

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 279366 - Fix FCC2 handling when saving a message as draft. r=john.bieling,mkmelin

• Save a copy to an additional folder only if the message is actually sent.
• Ensure that the current draft is replaced in the drafts folder when FCC2 is set and the message is saved again.
• This also prevents the additional CC folder from becoming a drafts folder when a message is saved with FCC2 set.

Comment 19

[John Bieling]

Attachment: Bug 279366 - Adjust tests and documentation after D242713 changed handling of additional fcc. r=welpy-cw,aleca

The API currently expects save operations to honour the additional fcc,
which is no longer the case once D242713 lands.

This patch ensures that the send operations are not affected and
modifies the tests for the save operations to actually use an fcc and
verify that it is now ignored. The test modifications in D242713 simply
stopped using fcc altogether.

This patch also updates the API description.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/89112fead816
Fix FCC2 handling when saving a message as draft. r=john.bieling,mkmelin
https://hg.mozilla.org/comm-central/rev/f1c35448824e
Adjust tests and documentation after D242713 changed handling of additional fcc. r=welpy-cw,aleca