279496 - can't copy or paste in <input> and <textarea>

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Hermann Schwab]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050123
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050123

Mozilla BuildID 2005012305, Win98
I can´t paste here or in other fields, like the CVS checkin query.
Copying works, not in this textarea, but from the text above, outside. 
I can select text here, but the moment I right-click the selection vanishes.

Was working with buildID 2005012206, so there are only yesterdays check-ins to
consider: Bug 265003, bug 273092, bug 230605

Reproducible: Always

Steps to Reproduce:
1. copy text from somewhere
2. try to paste it in <input> or <textarea>
3. type some text in <input> or <textarea>, select it, right-click to copy.

Actual Results:  
right-click to paste: menu shows 'paste' inactive, though I can paste in an editor
right-click to copy: selected text gets unselected, menu shows 'copy' inactive.


Expected Results:  
Allow copying and pasting in <input> and <textarea>

I´m marking this critical, as the unability to paste a lengthy copied text into
a textarea may be considered as 'dataloss', or at least making the browser unusable.

Comment 1

[Hermann Schwab]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050123

Sorry, wrong bug mentioned:
Bug 265003  	Add CRL generation to crlutil

regressed from
Bug 256003  	Remove -moz-user-focus from html.css, forms.css, ua.css. It's been
deprecated from use in HTML.

I reinserted -moz-user-focus: normal; in forms.css, and can copy&paste.

Comment 2

[[e-mail]]

WFM in my Linux gtk1 nightly.
And I know I have the new .css files because I had a merge conflict in one.

Comment 3

[Hermann Schwab]

I noticed this bug when I wanted to file a bug. As I´m using zips, I just
renamed the folder and unzipped the preceding nightly. When I had time, I
rebooted windows, started todays buggy build and verified my observations.
Then I looked at yesterdays checkins, I looked at that patch, and decided it´s
worth a try to restore the css, though not knowing what I´m doing.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/style&command=DIFF_FRAMESET&file=forms.css&rev1=3.95&rev2=3.96&root=/cvsroot
I just restored the changes made in line 98 and 119 in file 
mozilla\res\forms.css, and saw that the bug was fixed, at least in textarea.

Maybe I´m seeing this as I´m using zip builds, not the installer build using the
GRE?

Comment 4

[Mats Palmgren (inactive)]

WFM, Linux debug build, 20 minutes old. Maybe it's Windows only?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Hermann: I use the 2005-01-23-05 installer build, and I see this as well, on
Windows XP.

Comment 6

[Martijn Wargers (dead)]

Maybe it is just better to back out the patch from bug 256003? Especially, since
this is really a serious bug and bug 265003 isn't really solving anything.

Comment 7

[Aaron Leventhal]

If the removal of -moz-user-focus did this, it shouldn't be too hard to find the
lines of code which should be using IsFocusable instead.

I found one line in the code which uses -moz-user-focus within HTML:
http://lxr.mozilla.org/seamonkey/source/content/events/src/nsEventStateManager.cpp#1855
I'm not sure what it does yet.

Comment 8

[Ryuichi KUBUKI]

*** Bug 279540 has been marked as a duplicate of this bug. ***

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

maybe this is related to this one:

https://bugzilla.mozilla.org/show_bug.cgi?id=220900

?

Comment 10

[Aaron Leventhal]

(In reply to comment #9)
> maybe this is related to this one:
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=220900
> 
> ?

It looks like it. I'll get to this tomorrow.

Comment 11

[Aaron Leventhal]

Attachment: 1) Keep -moz-user-focus: ignore entries, they affect blur supression 2) Modify nsXULPopupListener to use isFocusable()

Comment 12

[Aaron Leventhal]

*** Bug 220900 has been marked as a duplicate of this bug. ***

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 172323 [details] [diff] [review]
1) Keep -moz-user-focus: ignore entries, they affect blur supression  2)  Modify nsXULPopupListener to use isFocusable()

sr=bzbarsky

Comment 14

[Phil Ringnalda (:philor)]

*** Bug 279827 has been marked as a duplicate of this bug. ***

Comment 15

[Ivan Ičin]

Keyboard shortcut CTRL+v works, but I have the same problem with context menu,
Win XP

Comment 16

[Mats Palmgren (inactive)]

Comment on attachment 172323 [details] [diff] [review]
1) Keep -moz-user-focus: ignore entries, they affect blur supression  2)  Modify nsXULPopupListener to use isFocusable()

This works fine (context menu too). r=mats.palmgren

Did you consider using "frame->IsFocusable()" here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/accessible/src/xul/nsXULTab
Accessible.cpp&rev=1.22&root=/cvsroot&mark=110,126#110

I'm not so familiar with code under accessible/ but that method
does not seem to consider visibility for example.

Comment 17

[Aaron Leventhal]

Mats, I did consider using it there -- but for that XUL tab case in
accessibility IsFocusable() won't add anything I don't already have.

Checking in layout/style/forms.css;
/cvsroot/mozilla/layout/style/forms.css,v  <--  forms.css
new revision: 3.97; previous revision: 3.96
done
Checking in content/xul/content/src/nsXULPopupListener.cpp;
/cvsroot/mozilla/content/xul/content/src/nsXULPopupListener.cpp,v  <-- 
nsXULPopupListener.cpp
new revision: 1.125; previous revision: 1.124
done

Comment 18

[Hermann Schwab]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050127
BuildID 2005012706 verified fixed on <input> and <textarea>

Comment 19

[Worcester12345]

The menu items (copy and paste) work for me, but the right click does not work
any longer. I think the keyboard commands also work. I didn't see it mentioned
anywhere that the right click menu capability was going to be taken away. Just
wondering if this should be reopened or not. Thanks. 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050128
Firefox/1.0+ (bangbang023)

Comment 20

[Peter van der Woude [:Peter6]]

use an official build.
Maybe the Bambang build doesn't have that patch included ?

Comment 21

[Worcester12345]

(In reply to comment #20)
> use an official build.
> Maybe the Bambang build doesn't have that patch included ?

Just heard back from "Bangbang" (one of the more popular 3rd party builders, and
closest to "official" builds), and he said if it is in the "official" build, it
is in his, so that's not it. 

Still suggest this bug be REOPENED.

Comment 22

[Hermann Schwab]

(In reply to comment #19)
> The menu items (copy and paste) work for me, but the right click does not work
> any longer. I think the keyboard commands also work. I didn't see it mentioned
> anywhere that the right click menu capability was going to be taken away. Just
> wondering if this should be reopened or not. Thanks. 
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050128
> Firefox/1.0+ (bangbang023)

Have a look at http://forums.mozillazine.org/viewtopic.php?t=62390
[FX] bangbang023: 2005-01-28 [Trunk/Win32] (O2/GAL7/SSE2)

you need:
2) A processor that supports SSE2 instrucions

This build contains a patch that places "Print" in the context menu. The
developers refuse to listen to the needs of the users, so I will be using this
small bit of unofficial code until they do.
---

Do you have a CPU supporting SSE2? 
Imho SSE2 is Intel P4, and from AMD Sempron, A64, Opteron, but not AthlonXP.

Of course the patches which produced the regression leading to this bug, and the
patch here may have broken something in that inofficial, slightly modified build.
The build contains a modified context menu, so there is no reason to complain
over here that the context menu is not working. Please stop spamming this bug,
it is verified fixed in official builds.

Comment 23

[Hermann Schwab]

could it be that this bugfix caused regression in
Bug 286657 wrong width on <td> , percentage calculated twice.

https://bugzilla.mozilla.org/attachment.cgi?id=177805
rightclick on a td styled width=90% resizes it once more.