281236 - Fix deleting a folder that already exists in the Trash Folder

Status: RESOLVED DUPLICATE of bug 66763

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

I'm sure this is a dupe. I'd really like to fix this for 1.1. It always annoys
me that when you delete a folder to trash that has the same name as a folder
already in the trash, we won't let you. You have to go empty your trash and then
try again.

Instead of throwing up an error dialog, why not call MakeUnique on the folder
name under Trash and proceed with the delete (i.e. TestFolder-1, TestFolder-2).
I'd be curious to see how other mail clients handle this condition.

Comment 1

[WADA:World Anti-bad-Duping Agency]

When a local mail folder, next can be a easy solution.
 (1) Create a unique new sub-folder(eg. "yyyymmddhhmmss-suffix") under Trash.
 (2) Move all deleting folder/subfolders under it.
 (3) If possible, keep folder structure of deleted mail folder(including higer),
     for ease of undele operation by user
     (or by Thunderbird like "Undelete" by MS Win)
  Note: Above (1)&(2) is probably similar approach to MS Win's file delete,
        although I think MS bypasses path length problem very clevery.
        See file name/directry name under hidden "RECYCLER" directry on MS Win.    
If name length of the sub-folder is kept short, path length limit problem is
expected to be very rare, although this is probably not so rare when HFS is used
on MAC.
Sorry but I don't know on IMAP folder.

Comment 2

[WADA:World Anti-bad-Duping Agency]

If local Trash folder, posibility of file path length limit problem can be
reduced, because file name and folder name is independent on current Thunderbird.
 - Use file name of 1/1.msf, 2/2.msf, ... for unique sub-folder file under Trash.
 - Use mail folder name of "Deleted folders on yyyy/mm/dd hh:mm:ss seq=nn".
 - Keep the long folder name in "NN.msf".
Current "Mail Folder creation" function probably doesn't support above irregular
mail folders.
Introducing new folder creation function for above will probably be needed.

Comment 3

[David :Bienvenu]

yeah, Scott, we should just create a new folder name. That's easier for POP3
than it is for IMAP...

Comment 4

[David :Bienvenu]

Outlook does the obvious thing and appends a "1", "2", etc., to the duplicate
file name. I'm happy to do that.

Comment 5

[Scott MacGregor]

that seems reasonable to me. -1, -2...etc.

Comment 6

[Mike Cowperthwaite]

(In reply to comment #0)
> I'm sure this is a dupe.

Bug 66763.

Comment 7

[WADA:World Anti-bad-Duping Agency]

If I'm a developer, I surely choose David's way, and I never want to choose my
comment #0 way, although I request it if I order new mailer for me to vender. :-)

David, how folder name and file name are restored to original when
undelete(manual move to original place)?
Users have to rename folder manually?

Comment 8

[Magnus Melin [:mkmelin]]

*** Bug 305728 has been marked as a duplicate of this bug. ***

Comment 9

[Magnus Melin [:mkmelin]]

*** This bug has been marked as a duplicate of 66763 ***