282183 - sync xpfe listbox.xml with toolkit listbox.xml

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mike Connor [:mconnor]]

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: 2005.03.08 X2T diff report [Checked in: Comment 6]

Diff from Xpfe to Toolkit version.

These came from Toolkit versions:
{{
1.11	ben%bengoodger.com	2005-02-25 01:07		274712 - new
options dialog
1.2	blakeross%telocity.com	2002-11-10 18:25		Fix the delay
when arrow keying up and down in the themes/extensions listboxes (and other
listboxes).
}}

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> Created an attachment (id=176653) [edit]
> 2005.03.08 X2T diff report

This one would look simple enough for me to take:
What would be the expected non-regression test(s) for these changes ?

Comment 3

[Serge Gautherie (:sgautherie)]

(Jan: Could you update your address on <http://www.mozilla.org/owners.html> ?)

Comment 4

[[e-mail]]

Comment on attachment 176653 [details] [diff] [review]
2005.03.08 X2T diff report
[Checked in: Comment 6]

r+sr=me

The test would be to open e.g. Themes preferences and look how quickly it
responds to the arrow keys.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 271935 has been marked as a duplicate of this bug. ***

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 176653 [details] [diff] [review]
2005.03.08 X2T diff report
[Checked in: Comment 6]


Check in: { 2005-03-09 05:47	neil%parkwaycc.co.uk	mozilla/ xpfe/ global/
resources/ content/ bindings/ listbox.xml	 1.23 }

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> (From update of attachment 176653 [details] [diff] [review] [edit])
> r+sr=me

(Neil, for the record, could you add these flags to the patch too ;->)

> The test would be to open e.g. Themes preferences and look how quickly it
> responds to the arrow keys.

I tried this and Languages (-> Add):
I can say it still works :-)
(then I could not tell the (VK_UP/VK_DOWN) speed difference ... anyway.)

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

serge, it was your patch :) no reason to assign to me.

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) nits, in the meantime [Checked in: Comment 10]

A few space nits,
and a |var| redeclaration.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 210717 [details] [diff] [review]
(Bv1) nits, in the meantime
[Checked in: Comment 10]


Check in: { 2006-02-24 07:16	bugzilla%standard8.demon.co.uk }

Comment 11

[Robert Kaiser]

SeaMonkey is now using toolkit, do we still need to port anything from xpfe's listbox.xml to toolkit or can we close this bug?

Comment 12

[[e-mail]]

No, the only bonus xpfe listbox has over toolkit is that it has none of the regressions caused by bug 281053 (which are few and far between for listboxes).

Comment 13

[Robert Kaiser]

in this case, I'm re-marking the bug fixed (due to it containing fixes that have been checked in). Please reopen or file new bugs if we run across something unexpected we still would need to port to toolkit.