283424 - URL with extra space created in enter_bug.cgi when using a format

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Håvard Wigtil]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050221 Epiphany/1.5.6 (Ubuntu) (Ubuntu package 1.0+dfsg.1-6ubuntu1)
Build Identifier: 

Using any "format" parameter with the enter_bug.cgi URL causes a space character
to be added after the product name when selecting a product on which to enter a bug.
The user will get an error about invalid product on the next page.


Reproducible: Always

Steps to Reproduce:
1. Go to http://landfill.bugzilla.org/bugzilla-tip/enter_bug.cgi?format=guided
2. Click on any product link.


Actual Results:  
Error page about invalid product

Expected Results:  
"Enter bug" form

The problem seems to be in the template
template/en/default/global/choose-product.html.tmpl, possibly triggered by the
check-in for bug 81642.
I will attach a possible patch shortly.

Workaround: Remove "%20" from the URL.

Comment 1

[Håvard Wigtil]

Attachment: Kill extra whitespace in choose-product.html.tmpl

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 175406 [details] [diff] [review]
Kill extra whitespace in choose-product.html.tmpl

r=wurblzap by inspection.

Comment 3

[Håvard Wigtil]

I don't have CVS access, could someone please check this in for me?

Note that the 2.18 branch doens't show this problem, at least not for me (or on
landfill.b.o). 
In theory there should also be extra whitespace there as I understand the
template, but the problem doesn't manifest itself.

Comment 4

[Shane H. W. Travis]

In bug 282983 I just made the same additions to choose-classification as I did 
in bug 86142 for choose-product... including the same errors, likely with the 
same results. I have applied the logic behind this fix on that file as well so 
the error you describe doesn't happen there too, and am checking it in as part 
of this fix.

Thanks for catching this!

2.18:
Checking in template/en/default/global/choose-product.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-
product.html.tmpl,v  <--  choose-product.html.tmpl
new revision: 1.10.2.1; previous revision: 1.10
done

Tip:
Checking in template/en/default/global/choose-classification.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-
classification.html.tmpl,v  <--  choose-classification.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/global/choose-product.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-
product.html.tmpl,v  <--  choose-product.html.tmpl
new revision: 1.12; previous revision: 1.11
done