285077 - New Thunderbird Options Dialog needs a Privacy icon

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Scott MacGregor]

Once I finish and land the new Thunderbird Options dialog (based on the work
done for Firefox), I'm going to have a new Privacy panel. Thunderbird Pinstripe
will need a new icon  (probably just a matter of re-using the one for Firefox)
for this panel.

Comment 1

[Frederic Bezies]

It could be great to have it for thunderbird 1.5 beta / final.

Windows version seems to be ok there :(

Comment 2

[Scott MacGregor]

it's already in the 1.1 bucket

Comment 3

[Frederic Bezies]

So, any chance to see it on the trunk, or should I have to switch to gecko 1.8 branch to have it ?

Comment 4

[Scott MacGregor]

pretty hard to find a build that has a fix when the bug is still in the open
state :)

Comment 5

[Scott MacGregor]

Kevin, it is pretty easy to take the privacy icon from Firefox's pinstripe theme
and put it into our image map for the preference icons in thunderbird?

Comment 6

[Kevin Gerich]

building now. I'll have an update by tomorrow morning at the latest

Comment 7

[Kevin Gerich]

Attachment: Adds privacy icon, plus "pressed" state to all icons, plus some style cleanup

Comment 8

[Kevin Gerich]

Attachment: privacy panel screen shot

Comment 9

[Scott MacGregor]

Comment on attachment 193799 [details] [diff] [review]
Adds privacy icon, plus "pressed" state to all icons, plus some style cleanup

I can check this into the branch if you want if you send me the new image.

Comment 10

[Kevin Gerich]

Attachment: new mail-options.png

Thanks Scott

Comment 11

[Scott MacGregor]

fixed branch and trunk

Comment 12

[Asaf Romano (gone)]

Kevin, this change has really regressed the look&feel of firefox's prefs dialog.

Comment 13

[Kevin Gerich]

(In reply to comment #12)
> Kevin, this change has really regressed the look&feel of firefox's prefs dialog.
> 

In what way? Screenshot please? :)

Comment 14

[Asaf Romano (gone)]

Attachment: One example

For example, see the tab-titles font-size comparing to the rest of the dialog.

Also, it made the dialog wider (too much IMO).

Comment 15

[Asaf Romano (gone)]

Also notice spacing in the Content pane.

Comment 16

[Uri Bernstein]

Note that the changes made to the fonts here are similar to what I did in my
proposed patch for Bug 304643. I compensated for the font size increase by
reducing the dialog width (in ems).

Comment 17

[Asaf Romano (gone)]

Also, we're now using a differnet font size for radios (vs checkboxes), check
the "Tabs" tab.

Comment 18

[Scott MacGregor]

i can back out the CSS change if Kevin doesn't have a chance to post a fix,
although I suspect the fix will come before I have to do that :)

Comment 19

[Kevin Gerich]

I'll have a patch today

Comment 20

[Kevin Gerich]

patch for Firefox pref window cleanup in bug 304643

Comment 21

[Scott MacGregor]

can we reclose this then Kevin? sounds like your tracking the issues in 304643

Comment 22

[Grey Nicholson (they/them)]

This also applies to Windows - the current (temporary) Privacy icon is noticably
stretched.

Comment 23

[Marcia Knous [:marcia]]

Looks good using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.8b5) Gecko/20050928 Firefox/1.4. Adding verified keyword.