Closed
Bug 285374
Opened 20 years ago
Closed 13 years ago
sync xpfe colorpicker.xml with toolkit colorpicker.xml
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
VERIFIED
FIXED
mozilla13
Tracking | Status | |
---|---|---|
firefox13 | --- | fixed |
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(1 file)
Quoted from bug 282177 comments:
{{
------- Additional Comment #3 From Chris Thomas (CTho) 2005-03-08 06:59 PST
[reply] -------
Somebody unsync'ed colorpicker.xml
------- Additional Comment #4 From Gavin Sharp 2005-03-08 07:40 PST [reply] -------
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=colorpicker.xml&filetype=match&date=explicit&mindate=2005-02-25+01%3A07&maxdate=2005-02-25+01%3A07&cvsroot=%2Fcvsroot
}}
Assignee | ||
Updated•20 years ago
|
Keywords: helpwanted
![]() |
||
Comment 1•18 years ago
|
||
SeaMonkey is using toolkit now, is there still anything we need to port from xpfe colorpicker.xml to toolkit or can we close this bug?
Updated•16 years ago
|
Assignee: jag → nobody
![]() |
||
Comment 2•16 years ago
|
||
As far as I can see only one line left to port:
<http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=colorpicker.xml&branch=&root=/cvsroot&subdir=mozilla/xpfe/global/resources/content/bindings&command=DIFF_FRAMESET&rev1=1.18&rev2=1.19>
Which corresponds to:
<http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/colorpicker.xml#448>
Assignee | ||
Comment 3•13 years ago
|
||
Per comment 2.
(Untested.)
This comes from bug 292668.
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/colorpicker.xml#443
{
443 <property name="color">
...
448 this.mColorBox.setAttribute("style", "background-color: " + val);
...
454 <method name="initialize">
...
457 this.mColorBox.style.backgroundColor = this.color;
}
Attachment #597693 -
Flags: review?(neil)
Assignee | ||
Updated•13 years ago
|
Component: XUL → XUL Widgets
Depends on: 292668
Product: Core → Toolkit
QA Contact: jrgmorrison → xul.widgets
Updated•13 years ago
|
Attachment #597693 -
Flags: review?(neil) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 597693 [details] [diff] [review]
(Av1) Set background color as a property, not as an attribute
[Checked in: Comment 4]
https://hg.mozilla.org/mozilla-central/rev/7e1855af184c
Succeeded as
https://tbpl.mozilla.org/?tree=Try&rev=920bb07ca312
Attachment #597693 -
Attachment description: (Av1) Set background color as a property, not as an attribute → (Av1) Set background color as a property, not as an attribute
[Checked in: Comment 4]
![]() |
||
Comment 5•13 years ago
|
||
Thanks Serge!
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
status-firefox13:
--- → fixed
Target Milestone: --- → mozilla13
![]() |
||
Updated•13 years ago
|
Keywords: helpwanted
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 597693 [details] [diff] [review]
(Av1) Set background color as a property, not as an attribute
[Checked in: Comment 4]
Ftr, this had already been done by
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/toolkit/content/widgets/colorpicker.xml&rev=HEAD&mark=1.17
It looks like it was missed somehow during the cvs->Hg transition :-/
(Note that this is odd, as r1.17 is tagged with HG_REPO_INITIAL_IMPORT.)
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Assignee | ||
Comment 7•13 years ago
|
||
(In reply to Philip Chee from comment #2)
> As far as I can see only one line left to port:
I confirm, after digging into cvs and hg histories for these 2 files.
V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•