Closed Bug 285374 Opened 15 years ago Closed 8 years ago

sync xpfe colorpicker.xml with toolkit colorpicker.xml

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla13
Tracking Status
firefox13 --- fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file)

Quoted from bug 282177 comments:
{{
 ------- Additional Comment #3 From Chris Thomas (CTho)  2005-03-08 06:59 PST 
[reply] -------

Somebody unsync'ed colorpicker.xml


------- Additional Comment #4 From Gavin Sharp 2005-03-08 07:40 PST [reply] -------

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=colorpicker.xml&filetype=match&date=explicit&mindate=2005-02-25+01%3A07&maxdate=2005-02-25+01%3A07&cvsroot=%2Fcvsroot
}}
Keywords: helpwanted
SeaMonkey is using toolkit now, is there still anything we need to port from xpfe colorpicker.xml to toolkit or can we close this bug?
Assignee: jag → nobody
Per comment 2.
(Untested.)

This comes from bug 292668.

http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/colorpicker.xml#443
{
443       <property name="color">
...
448           this.mColorBox.setAttribute("style", "background-color: " + val);
...
454       <method name="initialize">
...
457           this.mColorBox.style.backgroundColor = this.color;
}
Attachment #597693 - Flags: review?(neil)
Component: XUL → XUL Widgets
Depends on: 292668
Product: Core → Toolkit
QA Contact: jrgmorrison → xul.widgets
Attachment #597693 - Flags: review?(neil) → review+
Comment on attachment 597693 [details] [diff] [review]
(Av1) Set background color as a property, not as an attribute
[Checked in: Comment 4]

https://hg.mozilla.org/mozilla-central/rev/7e1855af184c


Succeeded as
https://tbpl.mozilla.org/?tree=Try&rev=920bb07ca312
Attachment #597693 - Attachment description: (Av1) Set background color as a property, not as an attribute → (Av1) Set background color as a property, not as an attribute [Checked in: Comment 4]
Thanks Serge!
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla13
Keywords: helpwanted
Comment on attachment 597693 [details] [diff] [review]
(Av1) Set background color as a property, not as an attribute
[Checked in: Comment 4]

Ftr, this had already been done by
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/toolkit/content/widgets/colorpicker.xml&rev=HEAD&mark=1.17

It looks like it was missed somehow during the cvs->Hg transition :-/
(Note that this is odd, as r1.17 is tagged with HG_REPO_INITIAL_IMPORT.)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Depends on: 156459, 354065
Flags: in-testsuite-
Resolution: --- → FIXED
(In reply to Philip Chee from comment #2)
> As far as I can see only one line left to port:

I confirm, after digging into cvs and hg histories for these 2 files.

V.Fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.