292668 - Reorganise mailnews pref panes for an encoding one

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Ian Neal]

Both pref-viewing_messages.xul and pref-composing_messages.xul are a bit
cluttered and could do with some prefs moving out to a new pref pane.

Comment 1

[Ian Neal]

Attachment: New Encoding Pref Pane

Comment 2

[Ian Neal]

Attachment: Revised Composing Pref Pane

Comment 3

[Ian Neal]

Attachment: Revised Message Display Pref Pane

Comment 4

[Ian Neal]

Any thoughts?

Comment 5

[zug_treno]

I guess this would fix bug 199721?

Comment 6

[Ian Neal]

No that would be fixed by fixing bug 296695

Comment 7

[Ian Neal]

Attachment: Encoding patch v0.1

This patch:
* Moves encoding prefs from message display and composing into new pref pane
* Updates help to reflect changes

Comment 8

[Karsten Düsterloh]

Comment on attachment 195587 [details] [diff] [review]
Encoding patch v0.1

>Index: mailnews/base/prefs/resources/content/pref-viewing_messages.xul
>===================================================================

Opening this pref panel gets me this CSS error, but display seems to be okay:

CSS Error (chrome://messenger/content/pref-viewing_messages.xul :0.18): Error
in parsing value for property 'background-color'.  Declaration dropped.


>Index: mailnews/base/prefs/resources/locale/en-US/pref-viewing_messages.dtd
>===================================================================
> <!-- LOCALIZATION NOTE : (convertEmoticons.label) 'Emoticons' are also known as 'Smileys', e.g. :-)   -->
> <!ENTITY convertEmoticons.label           "Display emoticons as graphics">

The pref this text belongs to is also used to show/hide structs like *bold*,
/italics/, ^L (FF), etc., which is quite confusing. Do you think something like
"Display emoticons as graphics and allow structs like *bold*" could improve
this?

>Index: mailnews/compose/prefs/resources/content/pref-composing_messages.xul
>===================================================================

In Classic, the two spelling checkboxes are only slightly closer to each other
than to their non-spelling neighbors, which looks quite strange. Either there
should be no difference (which I'm in favour of) or it should be greater and
the autosave pref coming after?

>Index: mailnews/base/prefs/resources/content/pref-encoding.xul
>===================================================================

BTW: your patch is lacking the /mailnews/jar.mn changes for both
pref-encoding.xul and pref-encoding.dtd.

>+    <caption label="&messageDisplay.caption;"/>
>+    <hbox align="center">
>+      <label control="viewDefaultCharsetList"
>+             value="&viewDefaultCharset.label;" accesskey="&viewDefaultCharset.accesskey;"/>
>+      <menulist id="viewDefaultCharsetList" ref="NC:DecodersRoot" datasources="rdf:charset-menu"
>+                preftype="localizedstring" prefstring="mailnews.view_default_charset">

The encoding for message display is not persisted.
If I open pref dialog [from the browser], okay changes to the
viewDefaultCharsetList pref and open the pref dialog again,
viewDefaultCharsetList is back to Western. 
(The encoding below for composition is kept, though.)

>Index: mailnews/base/prefs/resources/locale/en-US/pref-encoding.dtd
>===================================================================
>+<!ENTITY forceCharsetOverride.label      "Apply default to all messages displayed (ignore character encoding specified by MIME header)">
[...]
>+<!ENTITY replyInDefaultCharset.label     "Always use this default character encoding in replies. (When unchecked, only new messages use this default.)">

I think these two texts should be as similar in their wording and syntax as
possible.

Comment 9

[Ian Neal]

Attachment: Expanded Encoding patch v0.1a

Changes since v0.1:
* Set a default value of "#000000" instead of "" for mail.citation_color
* Changed order of check boxes and removed gaps in composition pref panel and
updated help to reflected the changed order.
* Added missing jar file changes
* Changed first "sendDefaultCharsetList" to "viewDefaultCharsetList" in
pref-encoding.xul's _elementIDs so changes to message display encoding are
persisted.
* Revised text for forceCharsetOverride.label so it is similar to text in
replyInDefaultCharset.label

Comment 10

[Karsten Düsterloh]

Comment on attachment 195689 [details] [diff] [review]
Expanded Encoding patch v0.1a

>Index: mailnews/base/prefs/resources/locale/en-US/pref-encoding.dtd
>===================================================================
>+<!ENTITY forceCharsetOverride.label      "Always use this default character encoding when messages are displayed (ignore character encoding specified by MIME header)">

Full stop missing at end of sentence. ;-)

>+<!ENTITY replyInDefaultCharset.label     "Always use this default character encoding in replies. (When unchecked, only new messages use this default.)">

Comment 11

[Ian Neal]

Attachment: The one with the dot patch v0.1b

Changes since v0.1a:
* Added missing full stop.

Carried forward r= and requesting sr=

Comment 12

[Simon Montagu :smontagu]

Comment on attachment 197361 [details] [diff] [review]
The one with the dot patch v0.1b

Please change encoding.label and pref.encoding.title to "Character Encoding".

Comment 13

[Ian Neal]

This covers MIME encoding as well as Character Encoding so changing it might be
misleading...

Comment 14

[[e-mail]]

Comment on attachment 197361 [details] [diff] [review]
The one with the dot patch v0.1b

>-pref("mail.citation_color",                 ""); // quoted color
>+pref("mail.citation_color",                 "#000000"); // quoted color
You'd need moa=mscott for this; there are some colour picker bugs that don't
like empty strings, right? I doubt that this workaround is preferable.

> <!ENTITY warnOnSendAccelKey.label             "Confirm when using keyboard shortcut to send message">
>-<!ENTITY warnOnSendAccelKey.accesskey         "k">
>+<!ENTITY warnOnSendAccelKey.accesskey         "o">
I don't like this change because it's the fact that it's a keyboard shortcut
that's important. It would help if you could quote aaronlev (always assuming
that he agrees with you, of course!)

I think I noticed some more bare "Encoding"s, I guess I must have seen them in
the Help diffs.

sr=me on the rest.

Comment 15

[Ian Neal]

Attachment: The patch with character v0.1c (Checked in trunk / 1.8.1 branch)

Changes since v0.1b:
* Moved from "Encoding" to "Character Encoding" throughout
* Fixed colorpicker problem at the .xml level instead

Carrying forward r=

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 197927 [details] [diff] [review]
The patch with character v0.1c (Checked in trunk / 1.8.1 branch)

r=biesi on the colorpicker.xml change

Comment 17

[Ian Neal]

Comment on attachment 197927 [details] [diff] [review]
The patch with character v0.1c (Checked in trunk / 1.8.1 branch)

Checking in
mailnews/jar.mn;
new revision: 1.101; previous revision: 1.100
mailnews/base/prefs/resources/content/mailPrefsOverlay.xul;
new revision: 1.29; previous revision: 1.28
mailnews/base/prefs/resources/content/pref-viewing_messages.xul;
new revision: 1.49; previous revision: 1.48
mailnews/base/prefs/resources/content/pref-character_encoding.xul;
initial revision: 1.1
mailnews/base/prefs/resources/locale/en-US/mailPrefsOverlay.dtd;
new revision: 1.22; previous revision: 1.21
mailnews/base/prefs/resources/locale/en-US/pref-viewing_messages.dtd;
new revision: 1.25; previous revision: 1.24
mailnews/base/prefs/resources/locale/en-US/pref-character_encoding.dtd;
initial revision: 1.1
mailnews/compose/prefs/resources/content/pref-composing_messages.xul;
new revision: 1.48; previous revision: 1.47
mailnews/compose/prefs/resources/locale/en-US/pref-composing_messages.dtd;
new revision: 1.25; previous revision: 1.24
xpfe/components/prefwindow/resources/content/pref-help.js;
new revision: 1.22; previous revision: 1.21
xpfe/global/resources/content/bindings/colorpicker.xml;
new revision: 1.19; previous revision: 1.18
extensions/help/resources/locale/en-US/help-index1.rdf;
new revision: 1.45; previous revision: 1.44
extensions/help/resources/locale/en-US/help-toc.rdf;
new revision: 1.81; previous revision: 1.80
extensions/help/resources/locale/en-US/mail_help.xhtml;
new revision: 1.63; previous revision: 1.62
done

Comment 18

[Ian Neal]

Comment on attachment 197927 [details] [diff] [review]
The patch with character v0.1c (Checked in trunk / 1.8.1 branch)

Requesting a= for SM1.1a, need this is so room in pref panels for other patches already with a= for SM1.1a

Comment 19

[Robert Kaiser]

Comment on attachment 197927 [details] [diff] [review]
The patch with character v0.1c (Checked in trunk / 1.8.1 branch)

a=me for SeaMonkey 1.1

Comment 20

[Ian Neal]

Comment on attachment 197927 [details] [diff] [review]
The patch with character v0.1c (Checked in trunk / 1.8.1 branch)

Checking in (branch 1.8.1)
mailnews/jar.mn;
new revision: 1.99.2.4; previous revision: 1.99.2.3
mailnews/base/prefs/resources/content/mailPrefsOverlay.xul;
new revision: 1.27.6.2; previous revision: 1.27.6.1
mailnews/base/prefs/resources/content/pref-viewing_messages.xul;
new revision: 1.47.6.2; previous revision: 1.47.6.1
mailnews/base/prefs/resources/content/pref-character_encoding.xul;
new revision: 1.1.10.2; previous revision: 1.1.10.1
mailnews/base/prefs/resources/locale/en-US/mailPrefsOverlay.dtd;
new revision: 1.20.6.2; previous revision: 1.20.6.1
mailnews/base/prefs/resources/locale/en-US/pref-viewing_messages.dtd;
new revision: 1.23.6.2; previous revision: 1.23.6.1
mailnews/base/prefs/resources/locale/en-US/pref-character_encoding.dtd;
new revision: 1.1.10.2; previous revision: 1.1.10.1
mailnews/compose/prefs/resources/content/pref-composing_messages.xul;
new revision: 1.46.4.2; previous revision: 1.46.4.1
mailnews/compose/prefs/resources/locale/en-US/pref-composing_messages.dtd;
new revision: 1.23.4.2; previous revision: 1.23.4.1
xpfe/components/prefwindow/resources/content/pref-help.js;
new revision: 1.21.6.1; previous revision: 1.21
xpfe/global/resources/content/bindings/colorpicker.xml;
new revision: 1.18.8.1; previous revision: 1.18
extensions/help/resources/locale/en-US/help-index1.rdf;
new revision: 1.44.8.3; previous revision: 1.44.8.2
extensions/help/resources/locale/en-US/help-toc.rdf;
new revision: 1.78.4.4; previous revision: 1.78.4.3
extensions/help/resources/locale/en-US/mail_help.xhtml;
new revision: 1.62.2.4; previous revision: 1.62.2.3
done