285648 - Camino displays subframe's URL in location bar

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect, P1)

Description

[Prachi Gauriar]

When a page has a subframe, Camino will display the subframe's URL in the
location bar instead of the main page's.  NYTimes.com is a good example. 
Instead of http://www.nytimes.com, the location bar shows
http://ad.doubleclick.net/adi/N3016.nytimes.comSD6440/B1495671.6;sz=88x60;ord=2005.03.10.22.06.34?

This started showing up in the 20050309 nightly.

Comment 1

[Mike Pinkerton (not reading bugmail)]

can someone take a look at the checkins from that day and narrow it down? this
has happened before when someone forgot about embedding layers when making changes.

Comment 2

[Simon Fraser [no longer active]]

The most likely candidate looks like bug 284993.

Comment 3

[Chris Lawson (gone)]

*** Bug 285682 has been marked as a duplicate of this bug. ***

Comment 4

[Chris Lawson (gone)]

Partial Workaround: switch to another tab, then go back to the first tab. The
proper URL will reappear (though this doesn't fix the missing favicon).

cl

Comment 5

[Josh Aas]

Also, sometimes there will simply be no URL in the URL bar. I have my home page
set to slashdot and when I start the browser, after slashdot has loaded there
will  be nothing in the URL bar.

Comment 6

[louis bennett]

*** Bug 263695 has been marked as a duplicate of this bug. ***

Comment 7

[L. H.]

*** Bug 286414 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Pinkerton (not reading bugmail)]

*** Bug 286716 has been marked as a duplicate of this bug. ***

Comment 9

[Simon Fraser [no longer active]]

This is a very serious bug; a site could spoof another site by using a small
iframe with the url of the site they want to show in the url bar.

Comment 10

[Simon Fraser [no longer active]]

jst: this looks like a regression from your change in bug 284993.

Comment 11

[Simon Fraser [no longer active]]

Taking.

Comment 12

[Simon Fraser [no longer active]]

Attachment: Fix to filter out OnLocationChange calls for windows other than our own

I think what happened is that jst's patch may have changed the order in which
we get OnLocationChange for the page vs. subframes. But the real bug is that we
need to filter the OnLocationChange at the browser listener level.

Comment 13

[Simon Fraser [no longer active]]

I checked this in.

Comment 14

[Mike Pinkerton (not reading bugmail)]

is this something that should go on the branch? would it fix similar issues that
are reported on 0.8?

Comment 15

[Mike Pinkerton (not reading bugmail)]

this needs to go on the branch

Comment 16

[Samuel Sidler (old account; do not CC)]

*** Bug 286414 has been marked as a duplicate of this bug. ***