286367 - clear button disabled after quick search

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Andrew Schultz]

With linux seamonkey trunk build 2005031405 If I do a "quick" quick search (type
in the search bar and hit enter quickly), the clear button stays deactivated.  I
get these in JS Console:

Error: gSearchBundle has no properties
Source File: chrome://messenger/content/searchBar.js
Line: 106

Error: gSearchBundle has no properties
Source File: chrome://messenger/content/searchBar.js
Line: 65

It looks like 272856 switched the code path around, but it looks like
gSearchInput can get initialized in quite a few different places (which would
then prevent the call to GetDocumentElements), but gSearchBundle can only
initialized in GetDocumentElements.

Comment 1

[Andrew Schultz]

Attachment: patch

see fish in barrel.  shoot.

Comment 2

[[e-mail]]

Comment on attachment 177585 [details] [diff] [review]
patch

Hmm... maybe we should back out 272856 and fix it a different way?

Comment 3

[[e-mail]]

Hmm... so onSearchInput() is to blame here because to select the text it calls
GetSearchInput before onEnterInSearchBar().

Comment 4

[Jim Booth]

I'm seeing the exact same thing in Windows build 2005041905, including the
Javascript Console errors.  Changing OS to ALL.

Looks like a recurrence of Bug 277884.

Comment 5

[Ian Neal]

Comment on attachment 177585 [details] [diff] [review]
patch

>Index: searchBar.js
>===================================================================
> function onEnterInSearchBar()
> {
>-   if (!gSearchInput)
>+   if (!gSearchBundle)
>      getDocumentElements();

Wouldn't the following be better?
>+   if (!gSearchBundle || !gSearchInput)

Comment 6

[Andrew Schultz]

Well, there are four variables that get initialized by getDocumentElements and
all of them could get checked.  But gSearchBundle (or gStatusBar or
gClearButton) only get set in that function, while gSearchInput can get set by a
separate call to GetSearchInput (which is exactly what's happening in this bug).

Comment 7

[[e-mail]]

Comment on attachment 177585 [details] [diff] [review]
patch

This'll do for now, but I want to totally rewrite this to use a timed textbox
anyway ;-)

Comment 8

[Ulf Dunkel]

WFM (build 2005-07-30 Windows)

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Doesn't work for me. I don't see anything in the js console anymore, but the
'clear' button is still disabled after typing something.

Comment 10

[Matt Seitz]

I am seeing this problem running the 2005-11-20 nightly

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051120 SeaMonkey/1.5a

I see the following JavaScript errors:

Error: gSearchBundle has no properties
Source File: chrome://messenger/content/searchBar.js
Line: 106

Error: gSearchBundle has no properties
Source File: chrome://messenger/content/searchBar.js
Line: 65

Comment 11

[Ian Neal]

This might get fixed when bug 179050 gets fully fixed.

Comment 12

[Matt Seitz]

I tried adding 179050 to the "depends on" field, but I do not have permission to set that field.  Could someone set that field?

Comment 13

[Matt Seitz]

While we are waiting for Bug 179050 to get fixed, could the fix from Comment 7 get checked in so this problem gets resolved?

Comment 14

[Andrew Schultz]

I checked in the patch.  I don't see the bug now that bug 179050 is fixed, but this should provide robustification and perhaps catch an edge case.

Comment 15

[Matt Seitz]

Which branch received Attachment 177585 [details] [diff]?  I installed SeaMonkey 1.1a to get the fix for 179050, and this issue does seem fixed there.  But it would be nice to be able to also use the more stable SeaMonkey 1.0 branch.

Comment 16

[Andrew Schultz]

Comment on attachment 177585 [details] [diff] [review]
patch

requesting branch approval to fix bug 364060 on branch

Comment 17

[Robert Kaiser]

Comment on attachment 177585 [details] [diff] [review]
patch

This seemingly has baked on trunk for a very long time now, so giving straight a=me for SeaMonkey 1.1

Comment 18

[Andrew Schultz]

patch landed, bug 364060 is fixed-on-branch