Thunderbird OS X builds missing prompt alert icon

RESOLVED FIXED in Thunderbird1.1

Status

Thunderbird
General
P2
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Scott MacGregor, Assigned: mano)

Tracking

({fixed1.8})

Trunk
Thunderbird1.1
PowerPC
Mac OS X
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

12 years ago
I just noticed the password prompt for the Mac builds doesn't show the blue
globe icon that it used to for all question based prompts. 

I tracked this down to a change to mozilla\toolkit\global.css by bsmedberg as
part of the branding changes for Bug #282057. 

It changed the alert prompts to use an icon located at:

"chrome://branding/content/icon64.png"

But I see no such file called icon64.png in mozilla\toolkit\themes for it to use.
(Reporter)

Updated

12 years ago
Keywords: regression
Target Milestone: --- → Thunderbird1.1
mscott, I thought that icon was application specific (that icon was the "not
official branding" version of the Firefox logo. Do you want the same blue globe
for tbird, or another icon? Should it be affected by the
--enable-official-branding flag like it is for Firefox?
(Reporter)

Comment 2

12 years ago
ah I see what's going on. Does this mean that official firefox builds would get
a globe with a fox instead of the generic blue globe in these dialogs? Or is it
always the generic blue globe?

I guess I'm happy with the behavior we had before, which would be using the
generic blue globe for both regular and official builds since the fox wouldn't
make sense for an official thunderbird build.

cc'ing Kevin in case he wants to have a special thunderbird image in these alert
prompts that would have a generic and an an official form.
I'll add the generic globe so it's not blank, and Kevin can add a branded
version later.
The generic globe is fixed, but this should really have an app-specific icon
like Firefox does.
Assignee: benjamin → kevin
Keywords: regression

Comment 5

12 years ago
Created attachment 193841 [details]
Alert sheet with blank space for icon

I just built on the 1.8 branch (without the official branding flag) and I get
alert sheets without the icon. I get a message "No chrome package registered
for chrome://branding/content/icon64.png". Is my build not flaky or is this
still a problem?
(Reporter)

Comment 6

12 years ago
I see that too with official branding disabled actually.

With official branding, I get a blue globe.
(Reporter)

Comment 7

12 years ago
Benjamin, is this ifef correct:

http://lxr.mozilla.org/seamonkey/source/mail/base/jar.mn#47

I think this should be #ifdef MOZ_USE_GENERIC_BRANDING

although that wouldn't explain why icon64.png isn't showing up in generic builds
since it is outside of the ifdef.
(Reporter)

Comment 8

12 years ago
Well I think the ifndef should be an ifdef so I'm gonna correct it and Benjamin
can tell me if I'm doing something wrong :)

Fixed branch and trunk
*** Bug 311429 has been marked as a duplicate of this bug. ***
Taking...
Assignee: kevin → bugs.mano
Priority: -- → P2
Status: NEW → ASSIGNED
Created attachment 198920 [details]
icon64.png

goes to /mozilla/other-licenses/branding/thunderbird/content
Created attachment 198921 [details] [diff] [review]
patch
Attachment #198921 - Flags: review?(mscott)
(Reporter)

Comment 13

12 years ago
Comment on attachment 198921 [details] [diff] [review]
patch

thanks Asaf. Go ahead and check this into the branch and trunk.
Attachment #198921 - Flags: review?(mscott)
Attachment #198921 - Flags: review+
Attachment #198921 - Flags: approval1.8rc1+
Trunk:

Checking in other-licenses/branding/thunderbird/content/jar.mn;
/cvsroot/mozilla/other-licenses/branding/thunderbird/content/jar.mn,v  <--  jar.mn
new revision: 1.6; previous revision: 1.5
done
Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.87; previous revision: 1.86
done
Checking in icon64.png;
/cvsroot/mozilla/other-licenses/branding/thunderbird/content/icon64.png,v  <-- 
icon64.png
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
1.8 branch:
Checking in other-licenses/branding/thunderbird/content/jar.mn;
/cvsroot/mozilla/other-licenses/branding/thunderbird/content/jar.mn,v  <--  jar.mn
new revision: 1.5.2.1; previous revision: 1.5
done
Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.84.2.3; previous revision: 1.84.2.2
done
Keywords: fixed1.8
(In reply to comment #7)
> Benjamin, is this ifef correct:
> 
> http://lxr.mozilla.org/seamonkey/source/mail/base/jar.mn#47
> 
> I think this should be #ifdef MOZ_USE_GENERIC_BRANDING
> 
> although that wouldn't explain why icon64.png isn't showing up in generic builds
> since it is outside of the ifdef.

Right. and for that reason, i managed to break the icon in *non*-official
builds, Benjamin?

(Note the about window seem to be already broken there...)
OS: Windows XP → MacOS X
Hardware: PC → Macintosh
Created attachment 199155 [details] [diff] [review]
fix generic-branding builds
Attachment #199155 - Flags: superreview?(mscott)
Attachment #199155 - Flags: review?(benjamin)
(Reporter)

Comment 18

12 years ago
Comment on attachment 199155 [details] [diff] [review]
fix generic-branding builds

did you intend to remove the xpcnativewrappers part of the content branding
line?
Attachment #199155 - Flags: superreview?(mscott) → superreview+
Yeah, it's now turned on by default.
Comment on attachment 199155 [details] [diff] [review]
fix generic-branding builds

please keep the xpcnativewrappers ;-)
Attachment #199155 - Flags: review?(benjamin) → review+
Attachment #199155 - Flags: approval1.8rc1?
Checking in jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.89; previous revision: 1.88
done

Updated

12 years ago
Attachment #199155 - Flags: approval1.8rc1? → approval1.8rc1+
1.8 branch:
Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.84.2.5; previous revision: 1.84.2.3
done
(Reporter)

Comment 23

12 years ago
The 10/17 build today is has the generic icon in the mail start page instead of
the offical artwork. This looks like the only recent change that could have
broken that.

(Windows)
*weird*. Which icon (filename) is used in the start page? is it broken in other
places (read: about dialog)?
(Reporter)

Comment 25

12 years ago
(In reply to comment #24)
> *weird*. Which icon (filename) is used in the start page? is it broken in other
> places (read: about dialog)?

thunderbird-watermark.png

Rest of the branding looks ok. I believe I had this same problem when I tried to
fix this generic branding flag a couple months ago. I'll see if I can find the bug.
Created attachment 199842 [details] [diff] [review]
*do'h*

though, i'm not sure why it didn't happen for the rest of the branding package.
Attachment #199842 - Flags: superreview?(mscott)
Attachment #199842 - Flags: review?(benjamin)
Attachment #199842 - Flags: review?(benjamin) → review+
(Reporter)

Updated

12 years ago
Attachment #199842 - Flags: superreview?(mscott)
Attachment #199842 - Flags: superreview+
Attachment #199842 - Flags: approval1.8rc1+
1.8 branch:
Checking in Makefile.in;
/cvsroot/mozilla/mail/base/Makefile.in,v  <--  Makefile.in
new revision: 1.9.2.1; previous revision: 1.9
done

trunk:
Checking in Makefile.in;
/cvsroot/mozilla/mail/base/Makefile.in,v  <--  Makefile.in
new revision: 1.10; previous revision: 1.9
done
You need to log in before you can comment on or make changes to this bug.