286483 - Thunderbird OS X builds missing prompt alert icon

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P2)

Description

[Scott MacGregor]

I just noticed the password prompt for the Mac builds doesn't show the blue
globe icon that it used to for all question based prompts. 

I tracked this down to a change to mozilla\toolkit\global.css by bsmedberg as
part of the branding changes for Bug #282057. 

It changed the alert prompts to use an icon located at:

"chrome://branding/content/icon64.png"

But I see no such file called icon64.png in mozilla\toolkit\themes for it to use.

Comment 1

[Benjamin Smedberg]

mscott, I thought that icon was application specific (that icon was the "not
official branding" version of the Firefox logo. Do you want the same blue globe
for tbird, or another icon? Should it be affected by the
--enable-official-branding flag like it is for Firefox?

Comment 2

[Scott MacGregor]

ah I see what's going on. Does this mean that official firefox builds would get
a globe with a fox instead of the generic blue globe in these dialogs? Or is it
always the generic blue globe?

I guess I'm happy with the behavior we had before, which would be using the
generic blue globe for both regular and official builds since the fox wouldn't
make sense for an official thunderbird build.

cc'ing Kevin in case he wants to have a special thunderbird image in these alert
prompts that would have a generic and an an official form.

Comment 3

[Benjamin Smedberg]

I'll add the generic globe so it's not blank, and Kevin can add a branded
version later.

Comment 4

[Benjamin Smedberg]

The generic globe is fixed, but this should really have an app-specific icon
like Firefox does.

Comment 5

[Kevin Gerich]

Attachment: Alert sheet with blank space for icon

I just built on the 1.8 branch (without the official branding flag) and I get
alert sheets without the icon. I get a message "No chrome package registered
for chrome://branding/content/icon64.png". Is my build not flaky or is this
still a problem?

Comment 6

[Scott MacGregor]

I see that too with official branding disabled actually.

With official branding, I get a blue globe.

Comment 7

[Scott MacGregor]

Benjamin, is this ifef correct:

http://lxr.mozilla.org/seamonkey/source/mail/base/jar.mn#47

I think this should be #ifdef MOZ_USE_GENERIC_BRANDING

although that wouldn't explain why icon64.png isn't showing up in generic builds
since it is outside of the ifdef.

Comment 8

[Scott MacGregor]

Well I think the ifndef should be an ifdef so I'm gonna correct it and Benjamin
can tell me if I'm doing something wrong :)

Fixed branch and trunk

Comment 9

[Asaf Romano (gone)]

*** Bug 311429 has been marked as a duplicate of this bug. ***

Comment 10

[Asaf Romano (gone)]

Taking...

Comment 11

[Asaf Romano (gone)]

Attachment: icon64.png

goes to /mozilla/other-licenses/branding/thunderbird/content

Comment 12

[Asaf Romano (gone)]

Attachment: patch

Comment 13

[Scott MacGregor]

Comment on attachment 198921 [details] [diff] [review]
patch

thanks Asaf. Go ahead and check this into the branch and trunk.

Comment 14

[Asaf Romano (gone)]

Trunk:

Checking in other-licenses/branding/thunderbird/content/jar.mn;
/cvsroot/mozilla/other-licenses/branding/thunderbird/content/jar.mn,v  <--  jar.mn
new revision: 1.6; previous revision: 1.5
done
Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.87; previous revision: 1.86
done
Checking in icon64.png;
/cvsroot/mozilla/other-licenses/branding/thunderbird/content/icon64.png,v  <-- 
icon64.png
initial revision: 1.1
done

Comment 15

[Asaf Romano (gone)]

1.8 branch:
Checking in other-licenses/branding/thunderbird/content/jar.mn;
/cvsroot/mozilla/other-licenses/branding/thunderbird/content/jar.mn,v  <--  jar.mn
new revision: 1.5.2.1; previous revision: 1.5
done
Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.84.2.3; previous revision: 1.84.2.2
done

Comment 16

[Asaf Romano (gone)]

(In reply to comment #7)
> Benjamin, is this ifef correct:
> 
> http://lxr.mozilla.org/seamonkey/source/mail/base/jar.mn#47
> 
> I think this should be #ifdef MOZ_USE_GENERIC_BRANDING
> 
> although that wouldn't explain why icon64.png isn't showing up in generic builds
> since it is outside of the ifdef.

Right. and for that reason, i managed to break the icon in *non*-official
builds, Benjamin?

(Note the about window seem to be already broken there...)

Comment 17

[Asaf Romano (gone)]

Attachment: fix generic-branding builds

Comment 18

[Scott MacGregor]

Comment on attachment 199155 [details] [diff] [review]
fix generic-branding builds

did you intend to remove the xpcnativewrappers part of the content branding
line?

Comment 19

[Asaf Romano (gone)]

Yeah, it's now turned on by default.

Comment 20

[Benjamin Smedberg]

Comment on attachment 199155 [details] [diff] [review]
fix generic-branding builds

please keep the xpcnativewrappers ;-)

Comment 21

[Asaf Romano (gone)]

Checking in jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.89; previous revision: 1.88
done

Comment 22

[Asaf Romano (gone)]

1.8 branch:
Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.84.2.5; previous revision: 1.84.2.3
done

Comment 23

[Scott MacGregor]

The 10/17 build today is has the generic icon in the mail start page instead of
the offical artwork. This looks like the only recent change that could have
broken that.

(Windows)

Comment 24

[Asaf Romano (gone)]

*weird*. Which icon (filename) is used in the start page? is it broken in other
places (read: about dialog)?

Comment 25

[Scott MacGregor]

(In reply to comment #24)
> *weird*. Which icon (filename) is used in the start page? is it broken in other
> places (read: about dialog)?

thunderbird-watermark.png

Rest of the branding looks ok. I believe I had this same problem when I tried to
fix this generic branding flag a couple months ago. I'll see if I can find the bug.

Comment 26

[Asaf Romano (gone)]

Attachment: *do'h*

though, i'm not sure why it didn't happen for the rest of the branding package.

Comment 27

[Asaf Romano (gone)]

1.8 branch:
Checking in Makefile.in;
/cvsroot/mozilla/mail/base/Makefile.in,v  <--  Makefile.in
new revision: 1.9.2.1; previous revision: 1.9
done

trunk:
Checking in Makefile.in;
/cvsroot/mozilla/mail/base/Makefile.in,v  <--  Makefile.in
new revision: 1.10; previous revision: 1.9
done