289860 - RegSetValue() is obsolete

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Bernd]

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/base/regsetvalue.asp

this function should be replaced by RegSetValueEx as we do in many other places:

http://lxr.mozilla.org/seamonkey/search?string=RegSetValueEx%28

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch (compiles, not tested) [Moved to bug 287943]

Comment 2

[timeless]

for my reference, this function is available on nt3.1

Comment 3

[Boris Zbarsky [:bzbarsky]]

CTho, want to drive this in?

Comment 4

[[e-mail]]

Comment on attachment 180387 [details] [diff] [review]
patch (compiles, not tested)
[Moved to bug 287943]

The documentation for RegSetValueEx says that it only emulates RegSetValue if
the value name is null.

Comment 5

[Bernd]

Neil: do you have a url for where one could read this?

Comment 6

[[e-mail]]

I originally read that in the WIN32SDK.HLP file, but the current documentation
phrases it differently:

RegSetValue:
LPCSTR lpSubKey:
... The function sets the default value of the specified subkey. If this
parameter is NULL or points to an empty string, the function sets the default
value of the key identified by hKey.

RegSetValueEx:
LPCSTR lpValueName:
... If lpValueName is NULL or an empty string, "", the function sets the type
and data for the key's unnamed or default value.

Thus the two functions are only interchangeable if the value is NULL or "".

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 180387 [details] [diff] [review]
patch (compiles, not tested)
[Moved to bug 287943]

This patch was "fixed" and included in bug 287943 ;-)

Comment 8

[Serge Gautherie (:sgautherie)]

1.8 branch:
<http://mxr.mozilla.org/mozilla1.8/search?string=%5B%5EWin%5DRegSetValue%5B%5EEx%5D&regexp=on&case=on&filter=%5E%5B%5E%5C0%5D*%24&tree=mozilla1.8>
{{
/mailnews/mapi/old/mapi32/xpapi.cpp
    * line 154 -- BOOL retVal = (RegSetValue(hKey, pKey, REG_SZ, pStr, lstrlen(pStr) + 1) == ERROR_SUCCESS);
}}

1.9 trunk has another one:
{{
/modules/softupdt/src/nsWinReg.cpp
    * line 247 -- result = RegSetValue( HKEY_CLASSES_ROOT, subkey, REG_SZ, value, length );
}}

Comment 9

[Serge Gautherie (:sgautherie)]

Peter,

<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/modules/softupdt/src/nsWinReg.cpp&rev=1.5&mark=247#227>

I was going to (try and) remove all the |#ifdef WIN32| from the file.
But I noticed (and was puzzled by) the few |#if defined (WIN32) || defined (XP_OS2)|.

Could you check whether we want +/- of these ?
(and possibly submit a patch ?)

Thanks.

Comment 10

[Serge Gautherie (:sgautherie)]

David,

<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/mapi/old/mapi32/xpapi.cpp&rev=1.3&mark=154#142>

Does this file need to be fixed,
or should the </mailnews/mapi/old/*/*> directories be removed ?
(on 1.8 branch, and 1.9 trunk)

Thanks.

Comment 11

[David :Bienvenu]

mapi/old can be removed - we just use it to see how the previous mapi implementation worked, but it can be removed now.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #11)
> mapi/old can be removed

Well, I had already filed bug 289860 ;->

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to comment #12)
> Well, I had already filed bug 289860 ;->

Bah: bug 227649 !

Comment 14

[Peter Weilbacher]

(In reply to comment #9)
> <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/modules/softupdt/src/nsWinReg.cpp&rev=1.5&mark=247#227>
> 
> I was going to (try and) remove all the |#ifdef WIN32| from the file.
> But I noticed (and was puzzled by) the few |#if defined (WIN32) || defined
> (XP_OS2)|.
> 
> Could you check whether we want +/- of these ?
> (and possibly submit a patch ?)

Can anyone explain to me when and how that code is actually used? OS/2 contains a subset of the Win32 API dating back to 10 years or more, so if used that code will probably still be working on OS/2.

Comment 15

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> /mailnews/mapi/old/mapi32/xpapi.cpp

This file was removed by bug 227649.

> /modules/softupdt/src/nsWinReg.cpp

This (directory and) file exists in cvs but not in Hg.

R.Fixed