290172 - Pressing left or right arrow key in location bar causes refresh

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050413
Firefox/1.0+

1. Make a new profile
2. Open firefox with the new profile.
3. Wait for the google-firefox page to load
4. Place the curser in the location bar
5. Press left arrow key or right arrow key

Actual: Page refreshes
Expected: Caret moves in location bar, no refresh

Comment 1

[Steve England [:stevee]]

Expected behaviour in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2)
Gecko/20050411 Firefox/1.0+ (arrow key movement doesn't force a refresh)

Comment 2

[Steve England [:stevee]]

From IRC:
ajschult|zzz: stevee: the cursor moves (left or right)... with 2005041205 on
linux [(suite) the page is not refreshed; expected behaviour]

Comment 3

[Caleb]

WFM in build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050412 Firefox/1.0+ too

Comment 4

[Steve England [:stevee]]

Expected behaviour in the official nightly from
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050412
Firefox/1.0+

Comment 5

[Steve England [:stevee]]

I'd guess one of these checkins might have caused this:
bug 283777 , bug 289022 or bug 289730

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050413
Firefox/1.0+

ez repro with old profile too.
1.open FF
2.open any page
3.focus in the locationbar
4.press [end] to move the cursor to the end of the line
5.press [right arrow]
6.page reloads
7.focus/cursor is no longer in the locationbar

8.focus in the locationbar
9.press [home] to move the cursor to the end of the line
10.press [left arrow] .... 
11.page reloads
12.focus/cursor is no longer in the locationbar

Comment 7

[Tuukka Tolvanen (sp3000)]

let's try blaming bug 283777 for a start :)

Comment 8

[:Gavin Sharp [email: [e-mail]]]

This was caused by 283777, as far as I can tell. The easiest solution is
probably to check for an open popup (using mInput->GetPopupOpen) before calling
HandleEnter.

Comment 9

[José Jeria]

*** Bug 290270 has been marked as a duplicate of this bug. ***

Comment 10

[Chris Blore]

Requesting blocking-aviary1.1

Comment 11

[Mark Mentovai]

Attachment: fix

Restores location bar to proper working order.	This is a reimplementation of
the changes from bug 283777 attachment 175688 [details] [diff] [review].	Rather than naïvely call
HandleEnter any time a left or right arrow is pressed, only fill the text box
if the popup is open and has a selected item, then close any open popup. 
HandleEnter doesn't work in the location bar or search bar because pressing
enter in those contexts causes the browser to load the URL or perform the
search.

Comment 12

[Tuukka Tolvanen (sp3000)]

Comment on attachment 180740 [details] [diff] [review]
fix

setting victim on review request

Comment 13

[Kevin Brosnan]

*** Bug 290416 has been marked as a duplicate of this bug. ***

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 180740 [details] [diff] [review]
fix

this isn't in 1.0.3, 
thankfully, but this should go into 1.0.4 if there is one, but we'd need a
modified patch to replace what's on branch properly.  If you could do that it'd
be great.

I'll land this shortly, thanks a lot!

Comment 15

[Mike Connor [:mconnor]]

Checking in toolkit/components/autocomplete/src/nsAutoCompleteController.cpp;
/cvsroot/mozilla/toolkit/components/autocomplete/src/nsAutoCompleteController.c
p,v  <--  nsAutoCompleteController.cpp
new revision: 1.31; previous revision: 1.30
done

Mark, can you port this patch to the aviary 1.0.1 branch so we can take that
instead of the patch for bug 283777?  If not, please let me know.

Comment 16

[Mark Mentovai]

Pulling the 1_0_1 tree now.  Thanks, Mike.

Comment 17

[Mark Mentovai]

Bringing this back over to bug 283777 for work on the AVIARY_1_0_1 branch.  The
problem patch never landed there and thus this bug doesn't apply.  Attachment
180857 [details] [diff] is a port of this trunk patch to the 1.0.x branch.