Closed
Bug 291064
Opened 19 years ago
Closed 19 years ago
Helper app dialog incomplete for non-nsStandardURL types
Categories
(Toolkit :: Downloads API, defect, P1)
Toolkit
Downloads API
Tracking
()
VERIFIED
FIXED
mozilla1.8final
People
(Reporter: dveditz, Assigned: Gavin)
References
()
Details
(Keywords: fixed-aviary1.0.5, regression)
Attachments
(2 files)
1.12 KB,
patch
|
mconnor
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
1.17 KB,
patch
|
dveditz
:
approval-aviary1.0.5+
|
Details | Diff | Splinter Review |
Spun off from suite bug 290829; similar, but different symptoms and fix. The helper app dialog tries to protect any user:pass information from prying eyes. However, if the source URI is of a type that does not support .userPass then an exception is thrown and the dialog is not initialized properly. For example, try to load data:foo/bar,blahblahblah and note that there's no default for the radio buttons, no "Open" with dropdown, etc.
Assignee | ||
Comment 1•19 years ago
|
||
Same patch as the core version ported to toolkit.
Assignee | ||
Updated•19 years ago
|
Priority: -- → P1
Target Milestone: --- → Firefox1.1
Updated•19 years ago
|
Attachment #181231 -
Flags: review?(mconnor) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #181231 -
Flags: approval-aviary1.1a?
Assignee | ||
Updated•19 years ago
|
Whiteboard: [patch-r+] [checkin needed]
Comment 2•19 years ago
|
||
Comment on attachment 181231 [details] [diff] [review] Toolkit patch a=asa
Attachment #181231 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
Assignee | ||
Updated•19 years ago
|
Whiteboard: [patch-r+] [checkin needed] → [patch-r+][checkin needed][a+]
Assignee | ||
Comment 3•19 years ago
|
||
Checked in by timeless.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r+][checkin needed][a+]
Reporter | ||
Updated•19 years ago
|
Flags: blocking-aviary1.0.4?
Reporter | ||
Updated•19 years ago
|
Reporter | ||
Comment 4•19 years ago
|
||
*** Bug 291627 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 5•19 years ago
|
||
Patch against the branch. The other patch probably still applies, but a fresh patch doesn't hurt. Requesting approval for a simple, low risk regression fix. I don't have checkin access, so if someone could check this in once approved that would be great.
Attachment #185825 -
Flags: approval-aviary1.0.5?
Reporter | ||
Comment 6•19 years ago
|
||
Comment on attachment 185825 [details] [diff] [review] Branch patch a=dveditz for the branch. Land soon if you're going to
Attachment #185825 -
Flags: approval-aviary1.0.5? → approval-aviary1.0.5+
Reporter | ||
Updated•19 years ago
|
Whiteboard: have patch → need landing
Assignee | ||
Comment 7•19 years ago
|
||
Landed by mconnor, adding fixed-aviary1.0.5.
Keywords: fixed-aviary1.0.5
The Bonsai description for the branch checkin references the wrong bug (Bug 291094 instead of Bug 291064). http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=AVIARY_1_0_1_20050124_BRANCH&branchtype=match&dir=&file=mozilla%2Ftoolkit%2Fmozapps%2Fdownloads%2Fsrc%2FnsHelperAppDlg.js.in&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-06-15&maxdate=2005-06-16&cvsroot=%2Fcvsroot
Comment 9•19 years ago
|
||
verified fixed with 200506170x-1.0.5 firefox builds on linux fc3 and mac os x 10.4.1. the resulting helper app dialog now contains a choice between the Open with (button to Browse for app) and Save to Disk radiobuttons.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•19 years ago
|
Whiteboard: need landing
Updated•19 years ago
|
Flags: testcase+
Updated•17 years ago
|
Flags: in-testsuite+ → in-testsuite?
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•