291064 - Helper app dialog incomplete for non-nsStandardURL types

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P1)

Description

[Daniel Veditz [:dveditz]]

Spun off from suite bug 290829; similar, but different symptoms and fix.

The helper app dialog tries to protect any user:pass information from prying
eyes. However, if the source URI is of a type that does not support .userPass
then an exception is thrown and the dialog is not initialized properly.

For example, try to load data:foo/bar,blahblahblah and note that there's no
default for the radio buttons, no "Open" with dropdown, etc.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: Toolkit patch

Same patch as the core version ported to toolkit.

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 181231 [details] [diff] [review]
Toolkit patch

a=asa

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Checked in by timeless.

Comment 4

[Daniel Veditz [:dveditz]]

*** Bug 291627 has been marked as a duplicate of this bug. ***

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: Branch patch

Patch against the branch. The other patch probably still applies, but a fresh
patch doesn't hurt. Requesting approval for a simple, low risk regression fix.
I don't have checkin access, so if someone could check this in once approved
that would be great.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 185825 [details] [diff] [review]
Branch patch

a=dveditz for the branch. Land soon if you're going to

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Landed by mconnor, adding fixed-aviary1.0.5.

Comment 8

[kitchin]

The Bonsai description for the branch checkin references the wrong bug (Bug
291094 instead of Bug 291064).
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=AVIARY_1_0_1_20050124_BRANCH&branchtype=match&dir=&file=mozilla%2Ftoolkit%2Fmozapps%2Fdownloads%2Fsrc%2FnsHelperAppDlg.js.in&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-06-15&maxdate=2005-06-16&cvsroot=%2Fcvsroot

Comment 9

[sairuh (rarely reading bugmail)]

verified fixed with 200506170x-1.0.5 firefox builds on linux fc3 and mac os x 
10.4.1. the resulting helper app dialog now contains a choice between the Open
with (button to Browse for app) and Save to Disk radiobuttons.