293832 - label lost when moving message from IMAP to local folder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[sairuh (rarely reading bugmail)]

found using 20050509-trunk tbird build on Mac OS X 10.3.9. spun off from bug
127141 comment 24.

0. make sure you have and IMAP account. also create a subfolder under Local Folders.

1. label a message in your IMAP, eg, select a message and then select Message >
Label > Work. this example labels the message orange in the thread pane by default.

2. drag that message into a subfolder under Local Folders.

3. click on the subfolder in Local Folders and look at the thread pane.

expected: the label should still be orange.

actual results: the label is no longer there.

Comment 1

[Peter Lairo]

I have this on Win2k & WinXP. Please change Hardware/OS to All/All.

Comment 2

[Jeongkyu Kim]

If message is copied from local folder, new header is copied from existing one
using mDatabase->CopyHdrFromExistingHdr(). This guarantee that every attribute
stays after copying.

However, if message is copied _from server_ then new header is generated from
parsed message. And missing attributes are taken care by
CopyPropertiesToMsgHdr() - see code below. Currently, the function takes care of
junk status only. Because of this, label information is missing unless IMAP
server save the information and expose it through message source. I crated a
patch to take care of label also.

In nsMsgLocalMailFolder::EndCopy(),
... 
if (msgDb)
{
  nsresult result =
mCopyState->m_parseMsgState->GetNewMsgHdr(getter_AddRefs(newHdr));
  if (NS_SUCCEEDED(result) && newHdr)
  {
    // need to copy junk score and label from mCopyState->m_message to newHdr.
    if (mCopyState->m_message)
      CopyPropertiesToMsgHdr(newHdr, mCopyState->m_message);
    msgDb->AddNewHdrToDB(newHdr, PR_TRUE);
...

Comment 3

[Jeongkyu Kim]

Attachment: patch to copy label when message is copied from server

see comment #2
seeking r?

Comment 4

[Scott MacGregor]

Comment on attachment 183459 [details] [diff] [review]
patch to copy label when message is copied from server

this looks ok to me code wise. David will know if it is the right thing to do
for sure.

Comment 5

[Jeongkyu Kim]

mscott, thanks for your review.

Comment 6

[David :Bienvenu]

Comment on attachment 183459 [details] [diff] [review]
patch to copy label when message is copied from server

good job, thx. I'll try to shepard this in.

Comment 7

[Jeongkyu Kim]

david, thanks for your effort.

Comment 8

[chris hofmann]

Comment on attachment 183459 [details] [diff] [review]
patch to copy label when message is copied from server

a=chofmann

Comment 9

[David :Bienvenu]

re-assigning before marking fixed.

Comment 10

[David :Bienvenu]

thx very much,  Jeongkyu - fix checked into trunk.

Comment 11

[Mike Cowperthwaite]

*** Bug 303973 has been marked as a duplicate of this bug. ***