29473 - [DOM] ondblclick event not being fired

Status: VERIFIED WORKSFORME

(Core :: DOM: Events, defect, P3)

Description

[djoham]

From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; N; Linux 2.2.12-20 i686; en-US)

BuildID: 2000022308

I've checked on both button and select HTML items and it doesn't look like the
doubleclick event (ondblclick()) is ever being fired. According to the DOM1
specs that I'm
reading(http://www.w3.org/TR/REC-html40/interact/forms.html#edef-SELECT) and
(http://www.w3.org/TR/REC-html40/interact/forms.html#edef-BUTTON) ondblclick
should be supported by both of these elements.

This bug may be related to bug 9140, although that one only talks about image
areas. Perhaps this is part of a larger problem?

Reproducible: Always

Steps to Reproduce: 1.open test case attachment 2 [details] [diff] [review].try to double click on the
button 3.try to double click on the select

Actual Results: No event is fired

Expected Results: I would expect the event to fire and the event handlers
defined to be called.

Comment 1

[djoham]

Attachment: test case

Comment 2

[Johnny Stenback (:jst)]

Joki, I believe this one is yours...

Comment 3

[Dawn Endico]

reassign to jst

Comment 4

[Johnny Stenback (:jst)]

I don't know why this got back to me, reassigning to joki again.

Comment 5

[Eric Murphy]

I have notice that on other elements, ondblclick works, but only with 1 click! 
This was a treecell item.

Also, this bug is still there in M15, as the testcase still does not work. It 
works in IE, however.

Comment 6

[joki (gone)]

*** Bug 33195 has been marked as a duplicate of this bug. ***

Comment 7

[joki (gone)]

Nominating nsbeta3

Comment 8

[joki (gone)]

*** Bug 43353 has been marked as a duplicate of this bug. ***

Comment 9

[Blake Ross]

*** Bug 41495 has been marked as a duplicate of this bug. ***

Comment 10

[joki (gone)]

Adding [DOM] prefix to bugs related to DOM Level 0, 1, or 2 
compatibility/compliance.

Comment 11

[vidur (gone)]

I believe this is an important one to have fixed by RTM. It's a significant DOM 
compatibility issue which, if let unfixed, will make it hard for web 
applications to implement common user interactions.

Comment 12

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Agreed. But what exactly is a double click? Click is defined as:

mousedown
mouseup
click

Is double click then

a) mousedown
   mouseup
   click
   mousedown
   mouseup
   click
   doubleclick

b) mousedown
   mouseup
   click
   mousedown
   mouseup
   doubleclick

c) mousedown
   mouseup
   mousedown
   mouseup
   doubleclick
?

Comment 13

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: FIX: Fire doubleclick after click iff clickCount==2

Comment 14

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I discussed this with vidur and joki, and we came to the conclusion that the
best way would probably be to fire a new event after the second click event. The
patch does that.

However, DOM 2 spec does not define double click events, and IE handles
doubleclicks differently. If you want follow the standards you should check the
click event and see how many clicks there were.

The bottom line still is that we should probably support this, and the easiest
way seems to be the attached patch. Haven't done heavy testing with it yet, but
at least the test case works.

Comment 15

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: TEST CASE: element with both onclick and ondblclick

Comment 16

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Has been reviewed by [e-mail].

Comment 17

[Nisheeth Ranjan]

Marking nsbeta3+...

Comment 18

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Checked in the fix. Marking fixed.

Comment 19

[Loco]

Mac OS Build 2000-09-04-08 still seems half broken (also checked on 2000-08-28-
08).  Sometimes it works, most it doesn't, so I'm reopening the bug and changing 
the Platform to Mac and OS to 9.0.4.

Comment 20

[Loco]

Also, another minor addition.  The following test:

http://slip/projects/marvin/html/button_ondblclick.html

is apparently working on Mac OS 9.0.4 running build 2000-09-04-08, but the funny 
thing is that when you click twice, the message telling you pops up, but if you 
move the mouse pointer over the text box it depresses the button.  Just by moving 
it over it, like ONMOUSEOVER or something.  Very funky.

Comment 21

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I see the funky effects on NT and Linux too,

http://slip/projects/marvin/html/button_ondblclick.html

However, the doubleclick event gets fired and the event handlers fire ok on NT
and Linux.

Comment 22

[Loco]

*** Bug 49954 has been marked as a duplicate of this bug. ***

Comment 23

[Loco]

Yup, the event gets fired on Mac and Win98, but I think the app is forgetting to 
release the last mouseclick....

Comment 24

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to Chris, thanks for help. Nisheeth said the minor problem reported 
by [e-mail] 2000-09-06 13:45 does not matter at this time - as soon as 
you can get the dbclick working on Mac just future this (or create a new bug for 
that problem, which is perhaps better).

Comment 25

[Peter Trudelle]

nsbeta3-/future, cc jrgm

Comment 26

[saari (gone)]

Targeting Mozilla 0.9

Comment 27

[selmer (gone)]

Should the summary of this bug now be "double click doesn't release first
click"?  Would that remaining symptom matter much or be seen often?

Comment 28

[John Morrison]

On mac 9.0, 20010226 build, the double click is reliably (always) firing
for either the select or button control in the testcase 2/27. I'm not sure
what "app is forgetting to release the last mouseclick" even means.

Comment 29

[bsharma]

Now, the event is being fired, but clicking on the OK button on the Alert dialog 
has no effect. The test case is provided in the url field.

Comment 30

[Jan Carpenter]

not my area, bequeathing to desale

Comment 31

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 32

[saari (gone)]

tested on mac and win2k and doubleclick appears to work fine. marking worksforme

Comment 33

[Sivakiran Tummala]

changing the qa to vladimire.

Comment 34

[Vladimir Ermakov]

verifying wfm on windows 98 2002-02-20-03-trunk and linux red hat
2002-02-13-08-trunk

Comment 35

[Todd A. Fisher]

If this is working can someone update
http://www.mozilla.org/docs/dom/mozilla/bug-events.html

Comment 36

[Gérard Talbot]

http://www.mozilla.org/docs/dom/mozilla/bug-events.html
 
has been updated accordingly.