294759 - Sync contentAreaUtils with the xpfe version

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Asaf Romano (gone)]

My target here is to fix various "Save As *" xpfe bugs which were not ported to
the toolkit version, not a zero k diff.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I think Mike Connor had started working on this, maybe ask him about it?

Comment 2

[Asaf Romano (gone)]

Attachment: work in progress

Comment 3

[Asaf Romano (gone)]

Comment on attachment 186463 [details] [diff] [review]
work in progress

known regressuib w/ this one:

 - save as text saves as html.
 - the web page title isn't used in some cases (e.g.
http://www.planet.mozilla.org)

Comment 4

[Asaf Romano (gone)]

Attachment: patch

fix those ^.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 186468 [details] [diff] [review]
patch

 const kSaveAsType_Complete = 0;   // Save document with attached objects
-const kSaveAsType_URL = 1;	   // Save document or URL by itself

do we need to remove this?  I know its implicit, but future changes might want
this.

At least leave it in, but commented out so its obvious what's between 0 and 2.

+  // We want to use cached data because the document is currently visible.
+  var dispHeader = null;

this should be contentDisposition here too for consistency with the previous
usage.

r=me with the various single line bracket style bits fixed, I didn't bother to
nit them all.

Comment 6

[Asaf Romano (gone)]

Attachment: patch

Comment 7

[Benjamin Smedberg]

Comment on attachment 187420 [details] [diff] [review]
patch

Please land this quickly.

Comment 8

[Asaf Romano (gone)]

Checking in toolkit/content/contentAreaUtils.js;
/cvsroot/mozilla/toolkit/content/contentAreaUtils.js,v  <--  contentAreaUtils.js
new revision: 1.71; previous revision: 1.70
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.46; previous revision: 1.45
done
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.444; previous revision: 1.443
done

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think this changed Firefox's behavior. When doing "Save Link As", it used to kick off the download and wait for the content-disposition header to arrive before showing the dialog, so it could present the filename suggested by the server. Now it shows the dialog immediately and guesses a filename based on the URL. This could be considered a regression, although I know there's some benefit in showing the dialog immediately. Was this an intended behaviour change?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #9)
> I think this changed Firefox's behavior. When doing "Save Link As", it used to
> kick off the download and wait for the content-disposition header to arrive
> before showing the dialog, so it could present the filename suggested by the
> server. Now it shows the dialog immediately and guesses a filename based on the
> URL.

That's bug 299372. This was a result of bug 160454.