Closed Bug 295040 Opened 20 years ago Closed 20 years ago

Switching folders doesn't work

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mozilla, Assigned: bzbarsky)

References

Details

(Keywords: regression, smoketest)

Attachments

(1 file)

Fix in-tree setters of window.location and document.location
8.67 KB, patch
jst
: review+
jst
: superreview+
asa
: approval-aviary1.1a1+
Details | Diff | Splinter Review 
20050520 trunk

Switching between mail folders doesn't work most of the time. The selected
folder highlights, but the message headers from the previous folder remain in
the header pane. Clicking back and forth will eventually get the proper headers
to display in the header pane.
Make that 20050521.
regression from Bug #281988
Blocks: 281988
Notes for any xpconnect guys that might be reading:
Exception... "Component is not available"
nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"
The line of code is
GetMessagePaneFrame().location = "about:blank";
The previous line of code is
if (GetMessagePaneFrame().location != "about:blank")
GetMessagePaneFrame() returns window.content for historical reasons.
Keywords: regression
We should retest once bug 295122 is fixed.
Depends on: 295122
So... how do I get to where I can reproduce this?  The tbird UI comes up
completely busted over here, the only menu option is "Folders", there is an XML
wellformedness error somewhere (there's a big gray bar with a single red caret
in it).

I get this in every single one of my tbird builds.
On a just downloaded Windows hourly build:

Error: uncaught exception: [Exception... "Component is not available"  nsresult:
"0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame ::
chrome://messenger/content/msgMail3PaneWindow.js :: ClearMessagePane :: line
1227"  data: no]

I don't see a pattern as to how it happens but if I click around from inbox to
other inboxes or folders, eventually it seems to happen.
marcia has seen this on Mac OS X as well.
OS: Windows XP → All
Hardware: PC → All
OK.  So is this reproducible with a newsgroup account?  I subscribed to a few
mozilla.org newsgroups and have been clicking about and there have been no issues...

Make sure to test builds pulled after "2005-05-23 11:00 PDT", in any case.  Is
this still a problem in such a build?
this was fixed by Bug #295122
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
whoops I clsoed this prematurely. It worked the first time I switched but then I
got the same JS error again.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
upgrading the status on this as the builds aren't really useable if you can't
read mail in different folders.
Severity: major → blocker
Keywords: smoketest
Scott, how do I go about reproducing this?  Do you see it with a newsgroup account?
just switch folders. yes I see it with news, imap and pop accounts. ditty for
local folders. Just start up thunderbird, click on a message and then try to
switch to another folder.  Note the inability to do so :)

You need to have displayed a message for us to try to clear the message pane
which triggers the failure. 
ditto for me as well --can also reproduce with RSS account (feeds). tested with
2005052305-trunk tbird bits on linux fc3.
> You need to have displayed a message

First time anyone mentioned that in this bug... (or in bug 281988).

Yes, with that addition to the steps to reproduce I can see this.  Looking into it.
So what's happening here is that XPCNativeWrapper enforces read-only-ness of IDL
attributes and window.location and document.location are both read-only.  The
setter is implemented via the nsWindowSH::SetProperty and
nsDocumentSH::SetProperty hooks.

For perfect compat we could try to make XPCNativeWrapper deal with these two
special cases (are there others?), I guess.  For a just-Thunderbird-for-now fix,
setting window.location.href instead of window.location should work.

jst, thoughts on hacking knowledge of location on window/document into
XPCNativeWrapper?
I think I'd rather see us change code that uses XPCNativeWrapper (directly or
not) be explicit and setting location.href when that's what they really want.
That patch should fix bug 295266 too, if I understand the steps to reproduce
correctly.
Blocks: 295266
Comment on attachment 184367 [details] [diff] [review]
Fix in-tree setters of window.location and document.location

r+sr=jst
Attachment #184367 - Flags: superreview?(jst)
Attachment #184367 - Flags: superreview+
Attachment #184367 - Flags: review?(jst)
Attachment #184367 - Flags: review+
Comment on attachment 184367 [details] [diff] [review]
Fix in-tree setters of window.location and document.location

Requesting approval for 1.8b2.	This fixes some more issues from the wrapper
separation.
Attachment #184367 - Flags: approval-aviary1.1a1?
Comment on attachment 184367 [details] [diff] [review]
Fix in-tree setters of window.location and document.location

a=asa
Attachment #184367 - Flags: approval-aviary1.1a1? → approval-aviary1.1a1+
Assignee: mscott → bzbarsky
Status: REOPENED → NEW
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
*** Bug 295222 has been marked as a duplicate of this bug. ***
*** Bug 295327 has been marked as a duplicate of this bug. ***
Is it just me or the bug is still here with News & Blogs folders?
1 highlight a feed folder
2 highlight an item of this feed
3 highlight an other folder
(tested on 2005052401 and 2005052411)
Oliver, how do I get to the point where I have the "News & Blogs" folders to
test with?  I tested this with newsgroup folders, and those do work...
RSS folders are working fine here. I'm not seeing the JS exception at all when
switching RSS folders. 
I am seeing the problem described in comment 26 in a thunderbird I just finished
building from fresh source. This is what I see in the JavaScript console:

Error: invalid 'in' operand window
Source File: chrome://messenger/content/mailCore.js
Line: 152
I haven't had the time to make sure when exactly it started, what I can say is:
- the 5/20 zip build is ok
- i can still reproduce with 5/24 17, newly generated %appdata%\Thunderbird
folder, only one account and 2 feeds added
- i see the above mentioned 'in' js error too (which i didn't see with 5/20)
- no problem switching to the thrash folder, only between two feeds

Steps:
1. Tools>Account Settings>Add Account>RSS News and Blog>...
2. Manage Subscriptions > Add a feed, eg
http://www.extensionsmirror.nl/peter6/firefoxfeed.xml and make sure it's fine
(might need restart)
3. Same as 2, eg http://www.mozilla.ru/unghost/thunderbird/thunderbirdfeed.xml
4. click a folder, then an item, then the other folder

--> Error: invalid 'in' operand window
Source File: chrome://messenger/content/mailCore.js
Line: 152
--> Hourglass mouse cursor
--> No switch
When subscribing to the feed did you disable article summaries?
Paste feed url and click ok. Default account settings.
Email folders still not working properly with 5/23/2005 build.

Please reopen.
using 2005052505-trunk tbird bits, I can still reproduce this going btwn an RSS
account (full page display, the default) and any other account (IMAP, POP, Local
Folders or news) --basically the same results Oliver sees in comment 30.

should this be reopened, or a new bug filed?
Flags: blocking-aviary1.1?
> Email folders still not working properly with 5/23/2005 build.

That would predate this patch being checked in.  Please do test with builds that
might conceivably have the bug fixed.  ;)

I'm looking into the RSS issues.
(In reply to comment #35)
> > Email folders still not working properly with 5/23/2005 build.
> 
> That would predate this patch being checked in.  Please do test with builds that
> might conceivably have the bug fixed.  ;)
> 
> I'm looking into the RSS issues.

Sorry, I was going back and forth with build dates. I think this one is OK now.
Seems to be working, but the "snap" or response seems to lag.
(In reply to comment #34)
>using 2005052505-trunk tbird bits, I can still reproduce this going btwn an RSS
>account (full page display, the default)
Summary display is the default in my version...
> should this be reopened, or a new bug filed?
Any new bug will only get duplicated against bug 295520.
Ah, yes.  Good catch, Neil.  That's using window.frames[i], indeed.  That's bug
295520 (and the patch there fixes the issue).
(In reply to comment #35)
> I'm looking into the RSS issues.

looks like the fix for bug 295520 did the trick for this remaining issue!
verifying fixed with 2005053113-trunk (tbird).
Status: RESOLVED → VERIFIED
Flags: blocking-aviary1.1?
Bug 300749 if very similar to this.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: