295465 - Add myspell to Tb source l10n

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

L10N teams need this and we want to give our users Tb with their spell dict.

Comment 1

[Toni Hermoso Pulido]

Catalan localizations have always also included several dictionaries by default:
Catalan, English (American and British), Spanish, French and Italian.
This is really appreciated by users since dictionary installation is still not
as 'easy' as it could be. Could new Thunderbird include these dictionaries as
well (letting aside the license problem)?

Comment 2

[Toni Hermoso Pulido]

Currently there is already code of different licenses in Mozilla CVS, as we can
read in http://www.mozilla.org/MPL/license-policy.html.
As I see, there are libraries from external projects such as jpeg with
non-MPL/LGPL/GPL license.
I think that dictionaries, since they are external projects/libraries as well,
and they are used by Mozilla applications, could be managed in a similar way.
If it's necessary, binary could have a warning in installation README about the
specific licenses of dictionaries. That's the same with artwork, isn't? 

Comment 3

[Benjamin Smedberg]

Toni, other licenses are only allowed in our shipped products when they are
compatible with the MPL/GPL/LGPL tri-license. Most of the dictionaries in
question are not compatible, or are at least legally questionable (it doesn't
actually make any sense to license a dictionary under a GPL/LGPL license, as it
it not "code"). In any case, that has no bearing on this bug, which is about the
build and installation systems necessary to get dictionaries installed
regardless of the licensing issues.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

ok. let's get this working.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch.gz

gzipped patch (size was too big due to en-US.dic move)

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch without en-US.dic|aff

Comment 7

[Benjamin Smedberg]

Comment on attachment 188544 [details] [diff] [review]
patch without en-US.dic|aff

Since we are not going to require every l10n to provide a dictionary, we need
to check that DICTIONARY_FILES exist before using them. This can be done with
the makefile $(wildcard) command or with the "-f" test in the command.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v2

Comment 9

[Benjamin Smedberg]

Comment on attachment 188548 [details] [diff] [review]
patch v2

"ls" is not good makefile-fu: please use $(wildcard
$(LOCALE_SRCDIR)/myspell/*.dic) or something equivalent

In addition, we're going to need changes to mail/installer/windows/basemail-win
to package the dictionaries in en-US.xpi instead of mail.xpi, and changes to
mail/locales/Makefile.in to build this directory in the libs-% target to make
extensions/myspell/locales and in the repackage-zip target to remove the en-US
dictionaries (if that's actually the plan, which it seems to be from this
patch).

Comment 10

[Scott MacGregor]

I'm pretty sure there are some nasty licensing issues with non english
dictionaries that prevent us from putting them in the source tree. This has come
up before IIRC.

Comment 11

[Robert Kaiser]

(In reply to comment #10)
> I'm pretty sure there are some nasty licensing issues with non english
> dictionaries that prevent us from putting them in the source tree. This has come
> up before IIRC.

We (bsmedberg, gandalf, Pike and the L10n community) know about that. We can
include a certain amount of dictionaries though. And before we can even think of
the licensing issues, which are different for each and every dictionary out
there, we have to support including them first.
This is what that bug and patch aims to do. Read the end of comment #3.
We'll deal with that somewhere else, once we have support for shipping them at all.

Comment 12

[Benjamin Smedberg]

mscott, we know about these issues: this patch is only the build infrastructure
so that if there are dictionaries with acceptable licenses we can use them.

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v3

wildcard used

Comment 14

[Benjamin Smedberg]

Comment on attachment 188669 [details] [diff] [review]
patch v3

did you read this patch before attaching it? ;-) please fix
topsrcdir/srcdir/VPATH to use the appropriate @macros@. And please use *.dic
and *.aff instead of *.* so that we don't pick up random other files (including
the CVS directory).

Comment 15

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 188669 [details] [diff] [review]
patch v3

I fixed topsrcdir,srcdir and VPATH locally and changed

DICTIONARY_FILES to grab only dic and aff files.

Comment 16

[Zibi Braniecki [:zbraniecki][:gandalf]]

checked in

Comment 17

[Chase Phillips]

Comment on attachment 188669 [details] [diff] [review]
patch v3

Probably the cause of bug 301969.