296039 - [PostgreSQL] Cannot create a new product

Status: RESOLVED FIXED

(Bugzilla :: Database, defect, P1)

Description

[Morten Werner Olsen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

I have configured Bugzilla 2.19.3 with PostgreSQL backend, and when I try to add
a new product a simple SQL-failure hits me:

Adding new product
Software error:

DBD::Pg::st execute failed: ERROR:  null value in column "sortkey" violates
not-null constraint
 [for Statement "INSERT INTO milestones (product_id, value) VALUES (5, '---')"]
at Bugzilla/DB.pm line 80
	Bugzilla::DB::SendSQL('INSERT INTO milestones (product_id, value) VALUES (5,
\'---\')') called at editproducts.cgi line 511



Reproducible: Always

Steps to Reproduce:
1. Setup Bugzilla 2.19.3 with PostgreSQL-backend
2. Login as admin
3. Add new product (default-values except name and description)

Actual Results:  
Adding new product
Software error:

DBD::Pg::st execute failed: ERROR:  null value in column "sortkey" violates
not-null constraint
 [for Statement "INSERT INTO milestones (product_id, value) VALUES (5, '---')"]
at Bugzilla/DB.pm line 80
	Bugzilla::DB::SendSQL('INSERT INTO milestones (product_id, value) VALUES (5,
\'---\')') called at editproducts.cgi line 511


Expected Results:  
new product added and a confirmation is printed

editproducts.cgi

Comment 1

[Frédéric Buclin]

mkanat, our Pg guru, can you reproduce?

Comment 2

[Max Kanat-Alexander]

Yep. It's a pretty easy fix. We just either need to add a DEFAULT statement to
that field (which is probably what I'll do) or add it to the INSERT statement.

Comment 3

[Max Kanat-Alexander]

Attachment: Add a DEFAULT to milestone.sortkey

This is a really simple patch. All the other "sortkey" fields have a DEFAULT of
0 in the database, except milestone.sortkey. So now I've added that DB default.

Comment 4

[Frédéric Buclin]

*** Bug 297608 has been marked as a duplicate of this bug. ***

Comment 5

[Marc Schumann [:Wurblzap]]

r=wurblzap by inspection.

I think this qualifies as a low-risk polish patch; requesting approval for 2.20
checkin.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Approval granted.

Comment 7

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.407; previous revision: 1.406
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.31; previous revision: 1.30
done