Closed Bug 297813 Opened 19 years ago Closed 19 years ago

Remove locale name from Windows registry keys

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox1.5

People

(Reporter: u60234, Assigned: benjamin)

Details

(Whiteboard: eta: 8/9 shouldn't block branch)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.8b2) Gecko/20050613
Firefox/1.0+

Using the firefox-1.0+.sv-SE.win32.installer.exe from latest-trunk-l10n/, the
install script for browser.xpi sets Windows registry keys with a "1.0+ (en-US)"
suffix. This is obviously wrong, but it does not seem to do any harm.

Are the locale name in these keys really necessary? Can it not just be removed?
Flags: blocking1.8b4+
chase, could you take a look?  possibly seen before we had locales building
properly in cvs?

/cb
Assignee: nobody → chase
Please keep me in the loop on any changes to config.it as I need to replicate
similar registry twiddling logic in the application update code (see bug 297147).
See also bug 297147 comment #2, where I describe possibly replacing the registry
setting done by the installer with that done by the update service.
Probably due to the fact that trunk localizations "repack" the en-US build.  We
have a self-imposed edict in build config not to touch browser.xpi during locale
repackaging.

If en-US is finding its way into some variable name that ends up in the
registry, we might be able to get around this by dropping the locale name from
that variable altogether.
Assignee: chase → nobody
Assignee: nobody → chase
Status: NEW → ASSIGNED
Potentially related: bug 301702, bug 301815.
Without help I won't get to this until 8/9.  From what I've read here and my
understanding of the problem, it shouldn't block the branch.
Whiteboard: eta: 8/9 shouldn't block branch
So, if we remove the locale from the registry key, then we prevent people from
installing more than one locale of Firefox 1.5b on their system.  I suspect that
being able to install multiple locales is nice for testing purposes at the very
least.  Perhaps we should instead fix the installer to write the proper locale
to the registry.  The update code writes the proper locale FWIW.
Chase, I'll take this unless you've already got code.
Assignee: chase → benjamin
Status: ASSIGNED → NEW
This just moves all the registry/shortcut code wholesale from browser.jst to
ab-CD.jst and it appears to do exactly what we want.
Attachment #192234 - Flags: superreview?(darin)
Attachment #192234 - Flags: review?(chase)
We need this fix for Thunderbird l10n builds, too.
Attachment #192234 - Flags: review?(chase) → review+
(In reply to comment #10)
> Chase, I'll take this unless you've already got code.

Thanks for the pickup here, Ben.
Comment on attachment 192234 [details] [diff] [review]
Move all the registy/shortcut writing to ab-CD.jst

excellent, sr=darin
Attachment #192234 - Flags: superreview?(darin) → superreview+
Attachment #192234 - Flags: approval1.8b4+
When migrating this to Thunderbird, we should localize "Thunderbird &Options"
(which seems to be in the same resulting install.js in mail.xpi), too. This
string is used in windows start menu.
Fixed on trunk for 1.8b4. Please file a separate bug about tbird.
Target Milestone: --- → Firefox1.1
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
For Thunderbird have a look in the existing bug 301702
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: