298134 - Js strict warning in bookmarksMenu.js: undefined property event.type

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dragging an URL from the location bar onto the bookmarks toolbar or removing the
bookmark throws following strict warning:

Warning: reference to undefined property event.type
Source File: chrome://browser/content/bookmarks/bookmarksMenu.js
Line: 923

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Why didn't you just reopen bug 291371? Especially since you verified it fixed
recently :).

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

You are right, I should remember this the next time. :( 

The strict warning occurs on that line:
http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarksMenu.js#973

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Martijn, this bug was caused by your patch of bug 266737. But you are not
accountable for. See bug 299476 for more information.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch with additional parameter for setTimeout()

We have to pass the additional parameter 'null' to setTimeout().

Comment 5

[Benjamin Smedberg]

Comment on attachment 188053 [details] [diff] [review]
patch with additional parameter for setTimeout()

r+a=me, please get somebody to land this quickly

Comment 6

[Asaf Romano (gone)]

Checking in bookmarksMenu.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v  <-- 
bookmarksMenu.js
new revision: 1.46; previous revision: 1.45
done