Closed Bug 266737 Opened 20 years ago Closed 19 years ago

Bookmarks Toolbar is blank/empty only showing chevron/">>" after being resized while minimized

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: rcchicago+allizgub, Assigned: martijn.martijn)

References

(Depends on 1 open bug)

Details

(Keywords: helpwanted, regression, Whiteboard: Please do not comment unless you have a patch)

Attachments

(2 files, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

If you add more bookmarks than fit on the screen using Bookmarks Manager while
Firefox is minimized the Bookmarks toolbar only shows a ">>" when you maximize
Firefox.  This is corrected by restarting Firefox.

Reproducible: Always
Steps to Reproduce:
1. Launch Firefox
2. Open Bookmarks Manager
3. Minimize Firefox
4. Add engough bookmarks to Bookmarks Toolbar using Bookmarks Manager to exceed
the widgth of the Bookmarks Toolbar
5. Maximize Firefox
Actual Results:  
Bookmarks Toolbar is blank, only showing ">>" is left justified.

Expected Results:  
Bookmarks Toolbar should be filled to edge, and ">>" should be right justified.
Confirmed with Windows FF branch build 2004-10-29-06-0.11
(Make sure to have the Browser minimized when performing the reported test)

Note: another method to make the contents of the Bookmarks Toolbar visible is to
add the current page to bookmarks: Bookmarks | Bookmark this page | Select the
Bookmark Toolbar Folder, Okay.

As many bookmarks as can fit on the toolbar are again shown with >> at the far
right.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Adding more bookmarks than fit to Bookmarks Toolbar in Bookmarks Manager when Firefox is minimized results in blank Bookmarks Toolbar only showing ">>" → Adding more bookmarks than fit to Bookmarks Toolbar in Bookmarks Manager when Firefox is minimized results in blank Bookmarks Toolbar only showing ">>"
*** Bug 267858 has been marked as a duplicate of this bug. ***
Bug 267858 was marked as a duplicate of this bug and closed. The symptoms of
that problem report are similar, but not the same. The problem reported in
267858 does not involve changing the bookmarks. I simply iconify and restore the
browser. As reported there, I first noticed this happening with RC1, where it
happened consistently. With RC2, it is sporadic. I've not seen it at all so far
today.
*** Bug 269344 has been marked as a duplicate of this bug. ***
*** Bug 268610 has been marked as a duplicate of this bug. ***
*** Bug 268277 has been marked as a duplicate of this bug. ***
If you look at the other bugs that were marked as duplicates, they aren't quite
the same, although they may share the same cause. My bookmarks toolbar is
completely replaced by the chevron, and it happens somewhat consistantly...
Whenever I leave my computer Firefox is minimized, and if I come back to it more
than a few minutes later, this bug has usually already happened... The longer it
has been, the more likely it's happened. And just to be clear, this has nothing
whatsoever to do with the Bookmark Manager, it happens just by minimizing and
restoring. I have duplicated it with a new profile, and just customizing the
toolbars a bit, not even sure if that's necessary for duplication, though.
This is the best way to reproduce the bug, although it happened to me
intermittently. My toolbar is like 75% full with only 1 instant of Firefox
opened and no new bookmarks added to it.
Another way to reproduce the bug.

1. All you need is only 1 site bookmarked in the Personal Bookmark Toolbar. This
site must require some plugin that you're missing, in order for the "Additional
plugins are required to display all the media on this page" to be displayed.
2. Click on that 1 site in the Personal Bookmark Toolbar and quickly minimise
Firefox.
3. Wait a while for the page to load completely and maximise Firefox.
4. You'll see similar results. However, this proves that it's not the amount of
bookmarks in the Personal Bookmark Toolbar that causes the problem.
(In reply to comment #9)
> Another way to reproduce the bug.
> 
> 1. All you need is only 1 site bookmarked in the Personal Bookmark Toolbar. This
> site must require some plugin that you're missing, in order for the "Additional
> plugins are required to display all the media on this page" to be displayed.
> 2. Click on that 1 site in the Personal Bookmark Toolbar and quickly minimise
> Firefox.

I tried something based on your info:
1. I have (5) tabs open.
2. Pick a bookmark from a folder within the Bookmark Toolbar (note: my entire
Bookmark Toolbar is folders--no individual bookmarks there). Be sure to pick a
site that will try to open a popup!
2. Minimize Firefox. Don't just click off it and put it behind other windows.
3. Restore firefox after the page has finished loading.
4. You will see the BookmarkToolbar iconified on the left side. AND you will see
the "firefox prevented this site from opening a popup window" message.

It definately has something to do with the blocked popup/missing plugin message.
When I perform the same steps and the site has NOT tried to open a plugin, the
bookmark toolbar appears correctly.

I think we've got this one pinned down. :)
-john
John, good job on finding steps to consistently reproduce the bug. I get the
same thing here each and every time. However, I'm not sure that the
popup-blocking or plug-in missing messages are related, because the same exact
thing happens when I leave FF minimized overnight without any pages loading in
the meantime. Any other ideas as to what might be happening?
*** Bug 271172 has been marked as a duplicate of this bug. ***
It shouldn't matter too much how you cause it to happen, since there only seems
to be one place that the bookmarks toolbar resizes itself, in bookmarksMenu.js#968

The easy answer would be that window.innerWidth is 0 in a minimized window,
though a little casual experimentation makes it seem like it isn't.
*** Bug 271172 has been marked as a duplicate of this bug. ***
*** Bug 270870 has been marked as a duplicate of this bug. ***
Use of Windows XP Professional's Remote Desktop Protocol also often results in a
blank Bookmarks Toolbar only showing ">>", although I am unsure exactly how to
reproduce it.
*** Bug 271281 has been marked as a duplicate of this bug. ***
Dunno why it didn't occur to me earlier that this must be a regression.
Unfortunately, it's right in the middle of archive.m.o's big gap in October:
20041010 doesn't have the bug, 20041017 does, and I don't have builds between
the two.

cc'ing dbaron, since the checkin for bug 227361 is the only thing that looks
related to someone who doesn't really know what they are talking about: feel
free to chastise me if I'm wrong. Still seeing the same thing in current trunk
on Windows (and no sign of non-Windows in any dups, so far).

Tweaking the summary for dups and the satisfaction of those duped; sorry if I
break your GMail threading.
Keywords: regression
Summary: Adding more bookmarks than fit to Bookmarks Toolbar in Bookmarks Manager when Firefox is minimized results in blank Bookmarks Toolbar only showing ">>" → Bookmarks Toolbar is blank/empty only showing chevron/">>" after being resized while minimized
*** Bug 271643 has been marked as a duplicate of this bug. ***
*** Bug 266189 has been marked as a duplicate of this bug. ***
*** Bug 267362 has been marked as a duplicate of this bug. ***
Assignee: vladimir → vladimir+bm
*** Bug 272799 has been marked as a duplicate of this bug. ***
*** Bug 272953 has been marked as a duplicate of this bug. ***
*** Bug 274243 has been marked as a duplicate of this bug. ***
*** Bug 274442 has been marked as a duplicate of this bug. ***
*** Bug 274513 has been marked as a duplicate of this bug. ***
From the dups, another popular way to trigger it is by playing games, which
typically switch resolution.
*** Bug 276151 has been marked as a duplicate of this bug. ***
This always happens when starting minimized, as from the startup folder.
I'm seeing this as well, but in a slightly different scenario.  Usually it
happens when I minimize Firefox with several tabs open, and then I'll lock my
user account.  When I come back to it, I only see the >> symbol.  Difference is
that I don't even have bookmarks which fill up the toolbar completely, they only
go about halfway, so the >> symbol doesn't normally appear anyway.  I'm going to
go ahead and request blocking 1.1 because it's been an annoyance for some time now.
Flags: blocking-aviary1.1?
Forgot to mention...the only way to get it back to normal that I've seen is
simply to close all the open tabs.  It then comes back on its own.
Ditto as comment #30, except it happens without locking the screen: all I need
is minimize the browser window for a couple minutes and then come back.

I restore the bookmarks toolbar by un-maximizing the browser window and
maximizing it again.
You're right, Marco, that fixes it for me, too.  I just maximize the window and
then restore (I usually don't browse maximized).
*** Bug 278104 has been marked as a duplicate of this bug. ***
I get this bug when I leave Firefox open and run Civ3 (which changes the
resolution of the screen).  When I end the game and switch back to Firefox, the
bookmarks toolbar is replaced with the chevrons >>.  However, it doesn't go away
by minimizing and maximizing the Firefox window.  I have to right click on the
chevrons, click customize, hit okay, and then the bookmarks toolbar returns to
normal.
I've read a number of the duplicate bugs that are supposed to be the same, but
the conditions to create it and how to fix it seems to be different in a lot of
them.  Are they really all the same bug?  I mean, I don't have to do anything
with the pop-up window or anything.  Just resize the screen.
(I'm just a user and don't know the inner workings of Firefox well, so I may not
know what I'm talking about, but it seems like they're all pretty varied.)
It started with 1.0RC1, and was not a problem with PR1).
I get this bug also. Here's how I can reproduce it:

1: Open 1 Firefox window
2: Maximise the window
3: Minimize the window
4: Switch to another user
5: Switch back to original user
6: Click the Firefox task

Results: Firefox should be maximised but the Bookmarks Toolbar will be collapsed
to >>

Workaround: Restore the window (not minimize or maximise) will fix the toolbar

I haven't tried this with multiple windows open or with different numbers of
items on the toolbar(I have 13). If others can reproduce it this way we can
investigate further.

Not a hugely bad bug, but one that detracts from the overall user experience of
a 'solid browser'.
Assignee: vladimir+bm → cst
Keywords: helpwanted
*** Bug 279917 has been marked as a duplicate of this bug. ***
*** Bug 268223 has been marked as a duplicate of this bug. ***
*** Bug 281788 has been marked as a duplicate of this bug. ***
A quick way to correct it is to press Ctrl-B twice.  I see this bug frequently,
I do use Remote Desktop and Fast User Switching, perhaps it's related.
*** Bug 268610 has been marked as a duplicate of this bug. ***
*** Bug 282744 has been marked as a duplicate of this bug. ***
Can anyone verify/wfm this bug using <a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=266737#c36">my test</a>?
Seemed to have been fixed in Firefox 1.0.1. Check it out guys.
(In reply to comment #44)
> Seemed to have been fixed in Firefox 1.0.1. Check it out guys.

It's not fixed.  I can still see it if I minimize a maximized Firefox, switch
users, switch back, and then look at Firefox again.  Note: I did install over a
1.0 installation, but a new profile still has the bug.  Could someone who did a
fresh install of 1.0.1 test it with this method?
> > Seemed to have been fixed in Firefox 1.0.1. Check it out guys.
> 
> It's not fixed.  I can still see it if I minimize a maximized Firefox, switch
> users, switch back, and then look at Firefox again.  Note: I did install over a
> 1.0 installation, but a new profile still has the bug.  Could someone who did a
> fresh install of 1.0.1 test it with this method?

Using Moox M2 Build of Mozilla Firefox 1.0.1 Freshly installed. Bug is still there. 
When mozilla starts minimized, it looks like this:
http://freefilehosting.net/player.cfm?id=5B22CAA5-CF1F-D571-AF1D62CDB3CE99CD
(In reply to comment #46)
> Using Moox M2 Build of Mozilla Firefox 1.0.1 Freshly installed. Bug is still
there. 

OF COURSE the bug is still there - that's why the status of this bug is "NEW". 
Until this bug's status is "RESOLVED", the bug will exist in any version you
download.

Moox builds are modified, and may not always be useful for bug reports.  Does he
even release source code, or is he still violating the license?
Whiteboard: Please do not comment unless you have a patch
Apparently with the Moox M3 build I'm using, this problem actually happens MORE
often with me.  VERY frustrating.  I love Firefox, but come on.  Let's get the
basics down.
Running into this problem on two different machines now.  One machine running
Windows 2000 Professional at 1600x1200, the other is XP w/ SP 2 at 1280x1024. 
Both installs are not using the same profile, but the number of bookmarks they
each contain are pretty much similar.  There are also folders on the navigation
toolbar that contains more bookmarks.  However, at the resolutions specified for
each machine, the number of bookmarks do not extend past the horizontal border.

The situation as explained in comment #7 (by Randy Oo) is precisely the same as
what I have been experiencing.  I have found that doing a Ctrl-B twice in a row
(for me, turns my Bookmarks sidebar off and then back on) will clear up the
problem.  The disappearing navigation toolbar always happens when my screen
saver kicks in (which changes screen resolution) and will usually happen 3 times
out of 4 whenever I minimize Firefox and either lock my computer or leave it
sitting for a while.  I don't remember this problem happening much before 1.0
release, but since installing 1.0.1, it seems to happen all the time.
Anyone still see this in Firefox 1.0.2? Eversince installing 1.0.2, I don't see
the >> anymore.
(In reply to comment #51)
> Anyone still see this in Firefox 1.0.2? Eversince installing 1.0.2, I don't see
> the >> anymore.

Dunno about 1.0.2, but this is still visible on trunk (20050329).
It happens to me this afternoon with 1.0.2 (a 3rd party build: Mozilla/5.0
(Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050324 Firefox/1.0.2
(djeter)) on WinXP SP2. I don't know why, I just minimized the window and the
">>" appears when I restored it.
occurs frequently with 1.0.2.
(In reply to comment #51)
> Anyone still see this in Firefox 1.0.2? Eversince installing 1.0.2, I don't see
> the >> anymore.

You know, I really haven't seen this thing in ages. I can't even reproduce it
anymore using my method below (comment #10--
https://bugzilla.mozilla.org/show_bug.cgi?id=266737#c10) I don't even recall
seeing it in 1.0.1. So I'd kinda forgotten about it until the messages that
showed up a couple of days ago.

So I'm wondering, could it have something to do with extensions? Now, I have no
idea what extensions I had installed at the time I made the above comment, but I
know they've all been updated since then.

Here's what I have now:
FireFTP v0.87
ieview v0.84
US Homeland Security Threat Level v0.4
Image Zoom v0.1.7
User Agent Switcher v0.6.1
Add Bookmark Here v0.5.3
Adblock v.5 d2 nightly 39
ForeCastFox v0.7
MySpeakeasy v0.35

The Speakeasy one is the only one I've added lately.

FWIW, I upgraded to 1.0.2 using the little upgrade button in the corner. I
didn't download, uninstall-old, install-new like I have in the past.

Just tested vs a 1.0 install with no extensions, and was able to easily
reproduce the chevron bug.

-john
Attached patch patch (obsolete) — Splinter Review
This subject has also been mentioned in comment 13, window.innerWidth seems to
be 0 in a minimized window. This is not the case when I make my own xul
testcase (also mentioned in comment 13, if I understand correctly), so I guess
that is a bug: window.innerWidth should not be 0 when minimized.
And that would make this a stopgap.
Oops! The bottom part of the patch should not be in here, only the code in the
resizeFunc: function should be in here.
Attachment #179589 - Flags: review?(mconnor)
Meant to mention, for the benefit of non-Windows-using reviewers: Martijn's
bandaid works for me, for all the ways I know how to trigger it (though I don't
know how to evaluate whether the eventListener's really getting removed).
Comment on attachment 179589 [details] [diff] [review]
patch

so if this gets hit when the window isn't focused, we add a listener and do the
resize when the window gets focus?  assuming this is tested properly and fixes
the issue, please go ahead and attach a new patch with a comment mentioning
that this is wallpaper, and re-request review, and we're off to the races.
Attachment #179589 - Flags: review?(mconnor) → review-
Attached patch patchSplinter Review
(I forgot to cc myself the last time)
I have tested it and it fixes the issue for me. I don't think I've seen it
causing any nastiness.

I've investigated the regression period a little:
firefox20041013 build and firefox20041017 build both return 0 for
window.innerWidth when in minimized state.
firefox20041013 build, however, calls the BookmarksToolbar.resizeFunc function
when maximizing. The firefox20041017 build not. I think what the
firefox20041017 build is doing is correct. Maximizing/minimizing is not a
resizing action.
But I think window.innerWidth should not return 0 when in minimized state.
Attachment #179589 - Attachment is obsolete: true
Attachment #180794 - Flags: review?(mconnor)
Comment on attachment 180794 [details] [diff] [review]
patch

Yeah, this makes sense, at least to me.
Attachment #180794 - Flags: review?(mconnor) → review+
*** Bug 294138 has been marked as a duplicate of this bug. ***
If someone could check the patch in, that would be great! 
I've submitted bug 296087 for the issue mentioned in comment 60.
Depends on: 296087
Attachment #180794 - Flags: approval-aviary1.1a2?
Comment on attachment 180794 [details] [diff] [review]
patch

a=shaver
Attachment #180794 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Assignee: cst → martijn.martijn
Flags: blocking-aviary1.1?
Target Milestone: --- → Firefox1.1
Checking in bookmarksMenu.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarksMenu.js,v  <-- 
bookmarksMenu.js
new revision: 1.44; previous revision: 1.43
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
I don't know if this is the same bug; but the fix to this appears old and I
still get the problem in Firefox 1.04 (WinXP, no extensions, small icons,
default theme):

I have put menu bar, icons, bookmarks toolbar and adress bar to the same
toolbar. Whenever I resize the window, the bookmarks toolbar shrinks by a few
pixels, and the adress bar moves to the left.
Sven, that's a different bug. This was a bug that occured on trunk builds.
You could file a new bug on the issue you see. But please first test if it also
happens on trunk builds, you can download those here:
http://ftp.scarlet.be/pub/mozilla.org/firefox/nightly/latest-trunk/
(those are not considered stable builds, so beware)
(In reply to comment #67)

Ah; thanks. I checked it (bug still occurring), and created Bug #296845
*** Bug 285714 has been marked as a duplicate of this bug. ***
*** Bug 307403 has been marked as a duplicate of this bug. ***
Although bug 307403 has been marked as a duplicate of this, the conditions I'm seeing are somewhat 
different. In my case, I don't have any tabs open, I'm not minimizing/resizing the browser window or 
changing resolution, and I don't have the bookmark manager open. Also, the bookmark toolbar isn't 
anywhere near full. As nearly as I can tell, it's caused simply by clicking on a link that opens another 
window, but I can't confirm that.  The workaround I've used is to de-select and re-select the bookmark 
toolbar from the view menu.
*** Bug 309644 has been marked as a duplicate of this bug. ***
Since installing 1.0.7 This bug seems to be happening alot more often and it
didnt take nearly as long for it to happen the first time.

Though this is probably a moot point if it has been fixed in 1.5
*** Bug 310867 has been marked as a duplicate of this bug. ***
*** Bug 311461 has been marked as a duplicate of this bug. ***
*** Bug 311929 has been marked as a duplicate of this bug. ***
*** Bug 312121 has been marked as a duplicate of this bug. ***
*** Bug 312837 has been marked as a duplicate of this bug. ***
*** Bug 313619 has been marked as a duplicate of this bug. ***
Ummm, am I just dumb...but how do you download and 'apply' the patch?  Am I supposed to know this already?
*** Bug 315506 has been marked as a duplicate of this bug. ***
Attached file my documents (obsolete) —
how can i change my color,background my profile in myspace?
Attachment #202948 - Flags: superreview?
Attachment #202948 - Flags: review?
Attachment #202948 - Flags: approval1.8rc2?
Attachment #202948 - Flags: approval-l10n?
Attachment #202948 - Flags: approval-aviary1.0.8?
Attached file can i be a model?lol (obsolete) —
how can i change my color,background my profile in myspace?
Attachment #202949 - Flags: superreview?
Attachment #202949 - Flags: review?
Attachment #202949 - Flags: approval1.8rc2?
Attachment #202949 - Flags: approval-l10n?
Attachment #202949 - Flags: approval-aviary1.0.8?
Attachment #202949 - Attachment is obsolete: true
Attachment #202949 - Attachment is patch: false
Attachment #202949 - Flags: superreview?
Attachment #202949 - Flags: review?
Attachment #202949 - Flags: approval1.8rc2?
Attachment #202949 - Flags: approval-l10n?
Attachment #202949 - Flags: approval-aviary1.0.8?
Attachment #202948 - Attachment is obsolete: true
Attachment #202948 - Attachment is patch: false
Attachment #202948 - Flags: superreview?
Attachment #202948 - Flags: review?
Attachment #202948 - Flags: approval1.8rc2?
Attachment #202948 - Flags: approval-l10n?
Attachment #202948 - Flags: approval-aviary1.0.8?
Attachment #202948 - Attachment mime type: text/plain → application/pdf
Attachment #202949 - Attachment mime type: text/plain → application/pdf
*** Bug 281641 has been marked as a duplicate of this bug. ***
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: