299473 - Not possible to enter data in account setting fields

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Michael Taeuber]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.9) Gecko/20050702 Firefox/1.0.5
Build Identifier: Thunderbird Version 1.0.5 (20050702)

It's not possible to enter the account settings in the input fields in the
dialog box 'Account settings' (e.g. Default identity, Server settings). The
input field is only some pixels high and you can't enter characters in it


Reproducible: Always

Steps to Reproduce:
1. Start Thunderbird
2. Try to enter text in field 'Default identity' in 'Account settings'
3.

Actual Results:  
Field is only some pixels high and it's not possible to enter text

Expected Results:  
Allow me to enter text

Comment 1

[Michael Taeuber]

It's a regression from the checkin of bug 296764.
The file '<appdir>/res/builtin/platformHTMLBindings.xml' was removed but it was
not added to the Java archieve '<appdir>/chrome/mail.jar' on the
AVIARY_1_0_1_20050124_BRANCH. 
After adding 'content/global/platformHTMLBindings.xml' to mail.jar Thunderbird
works without problems.
Also the missing version info (bug 299478) is displayed

Comment 2

[Tracy Walker [:tracy]]

confirmed on Windows and Linux 1.0.5 builds from 0705

Comment 3

[Jay Patel [:jay]]

CC'ing Jonas, since he put together the patch(es) for bug 296764.  Blocking 1.0.5.

Marcia is testing the suite to see if this is a problem there as well.

Comment 4

[Tracy Walker [:tracy]]

this also is blocking testing for bug 299133

Comment 5

[Jay Patel [:jay]]

cc'ing doron and aaron too, in case they can help out here.

Comment 6

[Doron Rosenberg (IBM)]

Actually, the file should be in toolkit.jar, since jar.mn puts it there.

Comment 7

[Jay Patel [:jay]]

Looks like bug 299478 is also the result of the problem mentioned here in
comment #1.  Can someone with a better understanding of this bug confirm that?

Comment 8

[Michael Taeuber]

(In reply to comment #6)
> Actually, the file should be in toolkit.jar, since jar.mn puts it there.

That's were the file is located in the Firefox build.
At Thunderbird, there is no toolkit.jar. I tried and created such an archieve,
but it didn't work. When storing 'platformHTMLBindings.xml' in mail.jar,
Thunderbird works.

Comment 9

[Michael Taeuber]

(In reply to comment #7)
> Looks like bug 299478 is also the result of the problem mentioned here in
> comment #1.  Can someone with a better understanding of this bug confirm that?

I won't say that I've got a better understanding of this bug, but I tried and put 
'platformHTMLBindings.xml' into the archive mail.jar and both bug 299473 and bug
299478 were fixed for me. 
To verify I removed the file from mail.jar and I could see both bugs again.

Comment 10

[Doron Rosenberg (IBM)]

As bsmedberg says on IRC:

http://lxr.mozilla.org/aviarybranch/source/mail/config/mail-jar.mn needs to be
modified to copy the file over.  Someone with a tbird aviary tree need to test this:

content/global/platformHTMLBindings.xml
toolkit/content/global/platformHTMLBindings.xml

Comment 11

[Doron Rosenberg (IBM)]

(In reply to comment #10)
> As bsmedberg says on IRC:
> 
> http://lxr.mozilla.org/aviarybranch/source/mail/config/mail-jar.mn needs to be
> modified to copy the file over.  Someone with a tbird aviary tree need to test
this:
> 
> content/global/platformHTMLBindings.xml
> toolkit/content/global/platformHTMLBindings.xml
> 
> 

Crappy bugzilla - both should be on the same line like the rest of the file.

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'm on it. Does this need to be done on the 1.7 branch too? Or does
seamonkey-mailnews import toolkit.jar?

Comment 13

[Jay Patel [:jay]]

QA tested this with the suite and did not report any problems, so this looks
like it's a Thunderbird only problem on the Aviary branch.

Comment 14

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

Comment 15

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This looks like it's needed on the trunk too, so i'll land there too once
reviewed  and approved

Comment 16

[Jay Patel [:jay]]

Comment on attachment 188374 [details] [diff] [review]
patch to fix

r+sr=brendan, a=jay 
Let's get this landed everywhere.  Thanks Jonas.

Comment 17

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in on the aviary-1.0.1 branch and the trunk. Thanks for the quick review!

Comment 18

[Jay Patel [:jay]]

Setting blocking1.8b3+ flag since this also made it on the Trunk (the bug fix
that caused this regression was also checked in on the Trunk, so we had to take
this patch there as well).

Comment 19

[Tracy Walker [:tracy]]

Verifuied with Windows Tbird 1.0.5 2005-07-06-07-aviary1.0.1