300408 - Add option to clear the Top Ten list

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, enhancement)

Description

[suguru2005]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050620 Camino/0.9a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050620 Camino/0.9a1

If you Clear History using the menu command under "Go > Clear History..." in
Camino, the list of sites you have visited is deleted, but the Top Ten List in
the Bookmarks remains unchanged.  I understand the Top Ten list is derived
solely from how often you visit sites in your bookmarks, but it seems like if
you're going to the trouble to clear the history of where you've been, you would
want to at least have the option of clearing your Top Ten List as well.  

Maybe a "Clear Top 10 List" checkbox in the Clear History... dialog box that
appears would be the best solution, if some people would prefer the current
behavior.  Or an option in Preferences > History to disable the Top 10 List
completely would be fine too.

Reproducible: Always

Comment 1

[Samuel Sidler (old account; do not CC)]

Do they clear when you Reset Camino (from the application menu)?

Comment 2

[L. H.]

That is mentioned in bug 257281 comment 14 15 and 16 but not decided.

Comment 3

[suguru2005]

In response to comment (1) below:

No, going to "Camino > Reset Camino..." does not clear the Top Ten List either.

Comment 4

[Mike Pinkerton (not reading bugmail)]

i don't think we should do this when we clear history, but we should have an
option to clear these. odd that reset camino doesn't do it, i guess it should as
well if the intent is to clear all record of your, ahem, habits.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

So add clearing the Top 10 to "Reset Camino..." repertoire and add a separate
(contextual menu in the BM Mgr?) way to clear just the Top 10?

Comment 6

[Ludovic Hirlimann [:Usul]]

Camino records in the bookmarkfile the # you visited the page. Reporter, mike
what behavior do we want for that clear menu :
  1) Reset To 0 the top10 bm
  2) Reset to 0 all bm

In case 1 the bm ranking from 11 to 20 will become immediatly (or maybe after a
refresh) the new top10.

In case 2 it make take some time when/if bookmakrs are in big number.

What way should I code this ?

Comment 7

[Mike Pinkerton (not reading bugmail)]

i say we need a way to clear *all*, and it's ok if it takes a while since the
user will have initiated the request.

Comment 8

[Ludovic Hirlimann [:Usul]]

Attachment: V 0 changes the bm item so their count is 0.

Asking a UI review more than anything here. Is a special menu Item Ok, should I
build a UI elsewhere ? Does the patch looks good ?

Comment 9

[Simon Fraser [no longer active]]

I don't think we want any new UI for this. Bookmark visit counts are too hidden
for most users to realize they are there. Nor am I sure that clearing history
should also clear the visit counts.

Is the top 10 list really useful at all (especially since the visit counting is
pretty bogus; it increases every time you reload a page)?

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 312034 has been marked as a duplicate of this bug. ***

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Pushing off since we can't agree on what to do; we can revisit this for 1.1 if it doesn't get wontfixed.

Comment 12

[Chris Lawson (gone)]

*** Bug 319476 has been marked as a duplicate of this bug. ***

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We eventually decided (in the course of bug 319491) that Reset Camino should reset  the visit counts of all bookmarks to 0, effectively clearing the Top 10 list (the reasoning being visit counts can reaveal browsing behavior so they should be cleared by Reset).

This bug is now only about exposing a separate, additional UI to do the same (reset visit counts of all bookmarks to 0).

Comment 14

[Chris Lawson (gone)]

*** Bug 324986 has been marked as a duplicate of this bug. ***

Comment 15

[Håkan Waara]

Per comment 13, this bug is now only about exposing UI to clear the top ten list.

I agree with Simon (comment 9) that UI for that isn't really to much value ... wontfix?

Comment 16

[Chris Lawson (gone)]

If nothing else, we should stick a "Clear" option to the contextual menu for the Top Ten collection in Bookmarks, especially if we're going to be moving Reset Camino somewhere.

cl

Comment 17

[Chris Lawson (gone)]

Based on the discussion here and on IRC, I now think we should give some serious thought to tossing out the Top Ten collection entirely. It's pretty bogus, as Simon says (though it may become less so when bug 311409 is fixed), a quick straw poll on IRC found people don't seem to use it much (Smokey likes it, though), and it seems to be the source of several fairly silly bugs (like this one) that people keep filing/requesting/etc.

I'll try to talk with pink and smfr tomorrow if I can.

cl

Comment 18

[Mike Pinkerton (not reading bugmail)]

i like it, we're not getting rid of it.

Comment 19

[Simon Fraser [no longer active]]

I'm OK with it, but I think users get confused about how it's generated, and that it's generated from bookmarks, and not history. Maybe we should re-think it, and generate it from history instead? 

Comment 20

[froodian (Ian Leue)]

^^^

If we do this, then we could get a lot of upset people unless we wait for Bug 251677, re: pr0n.

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Pushing this to 1.2 because we still have no consensus.

Comment 22

[Marcello Testi]

I just got a request from an italian forum about this. My (and the requester) assumption was that the Top 10 was generated from history.
Although I don't think that this apply to all, I suppose that many people clearing history have privacy concern and would like to get rid of all browsing behaviour information exposed by Camino.
OTOH it's true that a rough UI is available for this goal, by manually resetting the visits count for each "offending" bookmark in its info pane. (BTW, it would be nice although not deadly needed to have the list update without relaunching Camino): http://caminobrowser.org/documentation/bookmarks/#reset_top

After all, I'm not sure about what should be done; even a wontfix is probably reasonable.
My personal preference goes to adding a menu item to the "Actions" menu in the bookmarks manager.