301071 - Front page quicksearch uses onclick on the button instead of onsubmit on the form

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect, P2)

Description

[:Gavin Sharp [email: [e-mail]]]

I've diffed against the attachment in bug 279823.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: diff against template in the bug 279823

Comment 2

[Marc Schumann [:Wurblzap]]

Argh. Sorry, I didn't mean to steal a b.m.o bug.

Comment 3

[Gervase Markham [:gerv]]

Why is onsubmit() preferable to onclick()? Does onclick() not fire sometimes? Or is it an accessibility thing?

Gerv

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Sorry, I should have specified it in the summary. onClick requires a click, onSubmit fires anytime the users attempts to submit, such as pressing enter in the text field.

Comment 5

[Gervase Markham [:gerv]]

Is that true? I can enter "123" and press [Enter] in the b.m.o. front page field, and it does the right thing, including executing the JS which takes me to the bug rather than doing a search for "123".

Gerv

Comment 6

[:Gavin Sharp [email: [e-mail]]]

This bug was field because IE doesn't fire onClick in that case. The patch doesn't affect functionality in Mozilla, but fixes IE.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(and I think the fact that onclick is fired in that case is an accessibilty hack... onsubmit is more "correct")

Comment 8

[Gervase Markham [:gerv]]

Dave: can you apply this change directly to b.m.o.?

Gerv

Comment 9

[Gervase Markham [:gerv]]

Dave: is the b.m.o. index template maintained in source control somewhere? Or do we just hack the copy on the server?

Gerv

Comment 10

[Reed Loden [:reed]]

I have made this change on the index page. It will go live at the BMO upgrade.

See https://landfill.bugzilla.org/prodpatches/ for demo.