301823 - Firefox does not use the correct XP display theme objects for the tab close button

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Colin Freas]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

Users of Windows XP can change the OS wide 'theme'.  Some themes change the
minimize, maximize, and close buttons on windows.  The close button, in
particular, come in at least three flavors within a theme: CloseButton,
MDICloseButton, and SmallCloseButton.  Firefox should use the SmallCloseButton
or the MDICloseButton defined in the current Windows XP theme, rather than the
default, diminutive (and hideously ugly) 'red x' for the tab close button, which
seems hardcoded in.

Reproducible: Always

Steps to Reproduce:
1. Install a theme which changes the MDICloseButton and SmallCloseButton objects
within a theme.
2. Run Firefox.  Open some tabs.
Actual Results:  
UGLY TINY RED X!!!!  AHHH!!!

Expected Results:  
Used the color and image settings defined in the theme.

Comment 1

[Adam Guthrie]

The icon used for the close tab button is included in the default Firefox theme
and is not going to be changed depending on what Windows theme one is using. 

Probably INVALID.

Comment 2

[Dave Townsend [:mossop]]

Please see bug 244691 comment 11 for theme comments/suggestions.

Duping as per bug 246859.


*** This bug has been marked as a duplicate of 244691 ***

Comment 3

[Colin Freas]

This is not a dupe of 244691.  This is not a criticism of the Firefox *SKIN*.

This is a bug.  This is not how applications running under Windows XP are
supposed to behave.  You can not like that applications running under Windows XP
are expected to behave a certain way, but that does not change the fact that
they are supposed to behave.

Firefox uses a bright red 'X' button (similar to what Windows XP uses to mark
the window close button) for tabs, which is a smaller version of the bright red
X in the upper corner of the Firefox window.  Previously, it has used a
different, though equally unsightly, reddish X.  

Since the small red X it now uses is indistinguishable from the default
MDICloseButton and SmallCloseButton style of your average Windows XP theme, it
is understandable that when a user changes the style of the SmallCloseButton
and/or MDICloseButton within the current Windows XP theme, applications
throughout the system will reflect the change.  This is not the case with
Firefox.  It is the case with, as an example, the GIMP, which behaves correctly
when the MDICloseButton and SmallCloseButton are styled.

Since Firefox's behavior is not what is expected, this is a bug.  It is not a
'feature' of Firefox's skin.  

Comment 4

[James Ross]

Technically, neither of those theme components are correct for this, not least because the colours of the components match the *caption bar* of the theme, not the general window colour, and because Firefox uses a greyed out style for the buttons on inactive tabs, which simply does not exist in any theme.

Comment 5

[Wayne Mery (:wsmwk)]

James in comment #4
> Technically, neither of those theme components are correct for this,...

so you are suggesting both are incorrect?

Comment 6

[James Ross]

Yes, that is what I said. For thes purpose of this bug, neither is correct and both would suffer from the specific problems I mentioned in comment 4.