Closed Bug 302136 Opened 18 years ago Closed 18 years ago

Two clicks on "Install Now" button are necessary to install an extension.

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.8final

People

(Reporter: ShareBird, Assigned: benjamin)

References

Details

(Keywords: fixed1.8, regression, Whiteboard: [no l10n impact] has fix)

Attachments

(1 file)

Ignore internal focus/blur events as best we can, rev. 1
2.36 KB, patch
bugs
: review+
bugs
: approval1.8b4+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050725 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050725 Firefox/1.0+ ID:2005072517

From chob's description on MozillaZine Forum,
http://forums.mozillazine.org/viewtopic.php?p=1629779#1629779 :
"It required TWO clicks of the 'Install Now' button to install an extension. In
both occasions, the counter on the button counts down 2 seconds. I'm sure only
one click should be necessary (after the countdown of course.)"

Reproducible: Always

Steps to Reproduce:
1.Click a link to install an .xpi 
2.Installing Extension window appears. 
3.Greyed out "Install" button counts down 2 seconds, then ungreys out ready to
be clicked. 
4.After clicking, "Install now" button greys out, counts down 2 seconds again,
then ungreys out


Actual Results:  
After clicking, "Install now" again, the extension installs.



Expected Results:  
Extension should install on first click.
(In reply to comment #0)

I can confirm this bug on Linux (tarball) version as I get the same while
installing "Nightly Tester Tools" extension for example.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050725 Firefox/1.0+
ID:2005072521
 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050725
Firefox/1.0+ ID:2005072515
I see this too.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Requesting blocking as I guess this will have an effect on documentation if it
is not fixed. (Mentioning "Install now" must be clicked twice to install an
extension)
Flags: blocking1.8b4?
Confirm on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050726 Firefox/1.0+
Regressed between ID 2005072510 and ID 2005072521.
I am very sure this is due to the following checkin from security bug 239411
http://tinyurl.com/9uo3w

cc'ing bsmedberg
Blocks: 239411
*** Bug 302330 has been marked as a duplicate of this bug. ***
Keywords: regression
OS: Windows XP → All
Hardware: PC → All
Assignee: nobody → benjamin
Flags: blocking1.8b4? → blocking1.8b4+
Whiteboard: [no l10n impact] ETA 28-Jul
Bah, I was picking up internal focus/blur events (when switching between
buttons, for instance)... but the combination of blur/focus events that are
sent is less than appealing... on window blur you only get one blur event,
targeted at the XUL element currently in focus... on window focus you get
*three* focus events, two targeted at the window and one at the internal XUL
element. This works around this rather troublesome anomaly.
Attachment #190842 - Flags: review?(bugs)
Whiteboard: [no l10n impact] ETA 28-Jul → [no l10n impact] has patch, needs review beng
Will the patch fix the other issue where if you click on the disabled Install
button when it's counting down the counter resets and stops. Or should I file a
new bug for this?

That's bug 302265, and according to the whiteboard entry for it, yes, this patch
will also fix that problem.
(In reply to comment #8)
> Created an attachment (id=190842) [edit]
> Ignore internal focus/blur events as best we can, rev. 1
> 
> Bah, I was picking up internal focus/blur events (when switching between
> buttons, for instance)... but the combination of blur/focus events that are
> sent is less than appealing... on window blur you only get one blur event,
> targeted at the XUL element currently in focus... on window focus you get
> *three* focus events, two targeted at the window and one at the internal XUL
> element. This works around this rather troublesome anomaly.

I can confirm this patch does fix the problem on linux.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050730 Firefox/1.0+
(Swiftfox)


Fixed here for the last couple of days OS X 10.4.2 Mozilla/5.0 (Macintosh; U;
PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050731 Firefox/1.0+
Priority: -- → P1
Target Milestone: --- → Firefox1.1
also, if u click "install now" while its still counting down, it switches to 2.0
and stops. u have to click cancel and try to install it again.
Coldfusion, see comment #9 ;)
Comment on attachment 190842 [details] [diff] [review]
Ignore internal focus/blur events as best we can, rev. 1

r=ben@mozilla.org
Attachment #190842 - Flags: review?(bugs)
Attachment #190842 - Flags: review+
Attachment #190842 - Flags: approval1.8b4+
Landed on trunk. I'll land on the branch when I get some branch builds done.
Whiteboard: [no l10n impact] has patch, needs review beng → [no l10n impact] has fix
Hmm. Might this have caused the new bug  #304874 with extensions not installing
on the trunk?

I made a branch build today and manually added this patch and extensions don't
work on the branch either for me.
Landed on 1.8 branch.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Verified with Windows 2005-08-17-12-mozilla.1.8
and Linux 2005-08-18-06-mozilla.1.8
Status: RESOLVED → VERIFIED
This bug still occurs, with same behaviour, using the latest nightly of tbird on
osx 10.4.2.

I built tbird from source today, and was *never* able to install an extension.
Clicking "install now" would just restart the countdown every time.
(In reply to comment #20)
> This bug still occurs, with same behaviour, using the latest nightly of tbird on
> osx 10.4.2.
> 
> I built tbird from source today, and was *never* able to install an extension.
> Clicking "install now" would just restart the countdown every time.

I can confirm this behavior.

The Install Now button ends up in an endless loop, never installing. For both
Firefox and thunderbird on OSX 10.4.2)
please post the build ID's you're seeing this. 

This is fixed on the 1.5 branch for both Firefox and Thunderbird.
Verified with Deer Park on Mac 2005-08-22-06-mozilla1.8 and Thunderbird branch
on Mac 2005-08-22-05-mozilla1.8

this should be fixed ont he trunk as well,( see comment #16)
(In reply to comment #22)
> please post the build ID's you're seeing this. 
> 
> This is fixed on the 1.5 branch for both Firefox and Thunderbird.
> Verified with Deer Park on Mac 2005-08-22-06-mozilla1.8 and Thunderbird branch
> on Mac 2005-08-22-05-mozilla1.8
> 
> this should be fixed ont he trunk as well,( see comment #16)

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050822
Firefox/1.6a1

I'm not certain that the bug I'm experiencing is the same problem.  What's
happening for me is the infinite loop of the 'Install Now' button, not the click
twice to install problem.  If they are separate then let me know if I need to
file a new bug or if there's another already on this.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.