302838 - Update references to non-existing chrome files

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There are some references to non-existing chrome files when starting
Thunderbird. I think this should belongs to all OS. Following parts we have to
check:

* dist/bin/chrome/classic/skin/classic/messenger/messageKeywords.css

This stylesheet is referenced from within
mail/base/content/msgHdrViewOverlay.xul. It only exists for pinstripe and is empty:
 http://lxr.mozilla.org/seamonkey/source/mail/themes/pinstripe/mail/messageKeywords.css

Should we remove it completely?

* dist/bin/chrome/toolkit/content/mozapps/update/update.css

This isn't the correct filename. It is included in mailWindowOverlay.xul and
should be changed to updates.css.

* dist/bin/chrome/en-US/locale/en-US/global/findBar.dtd

Referenced from within toolkit/content/widgets/browser.xml this file doesn't
exist. It should be findbar.dtd. Correction of this part also resolves the
warning for Firefox.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Mail part updates all except findbar.dtd

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Toolkit patch updates findbar.dtd

Lxr also doesn't show me a findBar.dtd. So I think it has to be changed into
findbar.dtd.

Comment 3

[Benjamin Smedberg]

Comment on attachment 191118 [details] [diff] [review]
Toolkit patch updates findbar.dtd

Any clue as to when/why we changed from findBar -> findbar ?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #3)
> (From update of attachment 191118 [details] [diff] [review] [edit])
> Any clue as to when/why we changed from findBar -> findbar ?

Yes, that's happend 2004-11-30 20:48 with the aviary stuff landing patch from Ben:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=browser.xml&branch=&root=/cvsroot&subdir=mozilla/toolkit/content/widgets&command=DIFF_FRAMESET&rev1=1.45&rev2=1.46

Really long time ago. Why no-one noticed that? Mmh...

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry I miss-read. I think we use findbar.dtd since the checkin of the patch on
bug 178772.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #5)
> Sorry I miss-read. I think we use findbar.dtd since the checkin of the patch on
> bug 178772.

Err, I mean bug 279227.

Comment 7

[Benjamin Smedberg]

Comment on attachment 191118 [details] [diff] [review]
Toolkit patch updates findbar.dtd

no sr needed

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Patches checked in.

2005-08-02 15:31

mozilla/ mail/ themes/ pinstripe/ mail/ messageKeywords.css
mozilla/ mail/ base/ content/ msgHdrViewOverlay.xul 	1.14
mozilla/ mail/ base/ content/ mailWindowOverlay.xul 	1.114

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I forgot:

mozilla/ toolkit/ content/ widgets/ browser.xml 	1.70

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with current CVS build of Deer Park and Thunderbird.