303729 - trailing space in folder name are removed and folder not accessible anymore

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Michel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.6) Gecko/20050318 Firefox/1.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.6) Gecko/20050318 Firefox/1.0.2

Mail folder with trailing space are recorded on disk with the space e.g. 
test .sbd and are shown with the trailing space in Thunderbird. But when closing
and re-opening Thunderbird, it seems that Thunderbird remove the white space in
its list of folders, try to open the .sbd file, does not find one and create a
new one without the space e.g. test.sdb  And the correct folder test .sbd is not
listed anymore. But it is still on disk. Workaround to get your folder back:
remove test.sbd and rename test .sbd to test.sbd

Reproducible: Always

Steps to Reproduce:
1.In local folder create a new folder named "test " (I.e test with a trailing
white space). 
1.1 Highlight the newly created folder in the folder list : you will notice that
the space is still there. 
2.Move an exiting mail into the new folder
3.Close and re-open Thunderbird
4."test " is not shown anymore and has been replaced by "test" which is empty.
5. Check the files on your disk: there are two "test .sdb" and "test.sdb"




Workaround: Delete the file "test.sdb" and rename "test .sdb" to "test.sdb"

Comment 1

[zug_treno]

Maybe related to bug 232634, bug 234258 or Suite bug 233060?

Comment 2

[Atsushi Sakai]

Attachment: patch rv1

I confirmed this bug, except Step 2. is "Move an exiting folder", not "Move an exiting mail."

When creating file "test ", Windows actually creates "test".
It is same as Bug 229522 comment #28, " " instead of ".".

So, adding " " to patch of Bug 229522 fixes this bug.

Comment 3

[Scott MacGregor]

Comment on attachment 256796 [details] [diff] [review]
patch rv1

David would know better than I if this is the right thing to do as he was involved in Bug 229522.

Comment 4

[David :Bienvenu]

Comment on attachment 256796 [details] [diff] [review]
patch rv1

If it's really Windows that is stripping off the trailing space, and not some Mozilla code, then yes, this is the right fix.

I've pretty much decided that the hashing thing we do for "illegal" folder names was a bad idea - we should have tried to hew as close as possible to the original folder name.

Comment 5

[Scott MacGregor]

not a blocker, but we're going to take the patch. thanks for the contribution!

Comment 6

[Scott MacGregor]

Thanks for the patch! Fixed on the branch and the trunk.