304001 - Wierdness loading favicons after launch

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since Simon's bookmark checkins this weekend, I've noticed a couple of strange
behaviors when loading favicons from cache after launch.

(These assume all favicons in question are in cache and are not served for https
URL, since those two conditions are known issues with the favicon code.)

1. Go menu: loading favicons requires a) visiting a new non-local page (or,
sometimes, opening history), which loads all favicons in the Go menu OR b) the
page to be bookmarked in the Bookmarks *Menu* or the page to be bookmarked and
*displayed* on the Bookmarks Bar (not in a folder), which will load that favicon
only in the Go menu.  (This might be the remaining part of bug 294675?)

2. Bookmarks Toolbar folder: any favicon in a Bookmarks Toolbar *folder*
requires two loads of its toplevel Bookmarks Toolbar folder in order to be
displayed (all favicons in that toplevel folder's hierarchy displayed on second
opening; repeat for each additional toplevel Toolbar folder).

WONTFIX if appropriate.

Comment 1

[Simon Fraser [no longer active]]

Yeah, I think there are some remaining wrinkles.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 312237 has been marked as a duplicate of this bug. ***

Comment 3

[Chris Lawson (gone)]

More observations: favicons for secure (https) sites fail to load after a quit.
I have a bugzilla bookmark in my toolbar, and it's been failing miserably for
the last, oh, two months (since around the time this was reported). I can
reproduce this every time I quit.

Non-secure pages with favicons in the toolbar seem not to lose the favicon as
much, although I do think I've seen it happen a handful of times. I can't
reproduce it consistently at all.

cl

Comment 4

[Simon Fraser [no longer active]]

(In reply to comment #3)
> More observations: favicons for secure (https) sites fail to load after a quit.
> I have a bugzilla bookmark in my toolbar, and it's been failing miserably for
> the last, oh, two months (since around the time this was reported). I can
> reproduce this every time I quit.

https stuff is never put in the disk cache, so the images don't persist across
launches.

> Non-secure pages with favicons in the toolbar seem not to lose the favicon as
> much, although I do think I've seen it happen a handful of times. I can't
> reproduce it consistently at all.

They will disappear a) when you crash (the disk cache is cleared on next
launch), and b) when they get bumped from the cache.

We really need our own cache of favicons.

Comment 5

[Chris Lawson (gone)]

(In reply to comment #4)
> https stuff is never put in the disk cache, so the images don't persist across
> launches.

Would it be horribly horribly wrong to allow favicons to persist?

> They will disappear a) when you crash (the disk cache is cleared on next
> launch), and b) when they get bumped from the cache.

I think what I've mostly been seeing is (b). I was already aware of (a) and was
ignoring those instances.

> We really need our own cache of favicons.

Agreed.

cl

Comment 6

[Jasper]

Some related core bugs:

Bug 117895
Bug 114824

Comment 7

[Samuel Sidler (old account; do not CC)]

Simon, is this fixed by your favicon cache in bug 316937?

Comment 8

[Simon Fraser [no longer active]]

Yes.

Comment 9

[Samuel Sidler (old account; do not CC)]

Right, so isn't this fixed?