Last Comment Bug 304061 - Refresh (reload) button disabled while page is loading
: Refresh (reload) button disabled while page is loading
Status: VERIFIED FIXED
: fixed1.8.1
Product: Camino Graveyard
Classification: Graveyard
Component: Toolbars & Menus (show other bugs)
: unspecified
: PowerPC Mac OS X
-- normal (vote)
: ---
Assigned To: froodian (Ian Leue)
:
:
Mentors:
Depends on:
Blocks: 341853
  Show dependency treegraph
 
Reported: 2005-08-09 11:06 PDT by Samuel Sidler (old account; do not CC)
Modified: 2006-08-23 14:23 PDT (History)
5 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.34 KB, patch)
2006-06-17 17:36 PDT, froodian (Ian Leue)
bugzilla-graveyard: review+
hwaara: review+
mikepinkerton: superreview+
Details | Diff | Splinter Review

Description User image Samuel Sidler (old account; do not CC) 2005-08-09 11:06:10 PDT
While a page is loading, the refresh button is disabled, however, one can 
still "command-R" to refresh the page. This is not the desired behavior since 
the whole point of having the buttons separate is to allow one to refresh 
whilst the page is loading.
Comment 1 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2005-08-10 00:32:00 PDT
Are you sure this isn't just the hovering bug, bug 267403?
Comment 2 User image Samuel Sidler (old account; do not CC) 2005-08-10 00:38:17 PDT
Yep. I'm saying it's disabled while the page is loading, not when it's finished
loading.
Comment 3 User image Samuel Sidler (old account; do not CC) 2005-12-22 15:26:07 PST
Wevah, do you know much about this?
Comment 4 User image Wevah 2005-12-22 16:36:41 PST
I think we're just returning NO for -validateToolbarItem: when the page is loading.
Comment 5 User image froodian (Ian Leue) 2006-06-17 17:36:25 PDT
Created attachment 226029 [details] [diff] [review]
Patch
Comment 6 User image Nick Kreeger 2006-07-03 08:53:44 PDT
Shouldn't the refresh button *be* disabled when reloading?
Pink what do you think?
Comment 7 User image froodian (Ian Leue) 2006-07-03 09:07:00 PDT
Why should it be?  As sam says, this is part of the whole point of having two separate buttons, and if it works, why not let people do it?  Plus, the menu item is enabled while the page is loading, so the button certainly should be (or the menu item should be disabled).  I for one often reload while a page is still loading.
Comment 8 User image Nick Kreeger 2006-07-03 11:10:19 PDT
If this is the path that we want to go down, this should include the change from bug 267403 in BrowserWindowController to update the toolbar when the page had finished loading.
Comment 9 User image froodian (Ian Leue) 2006-07-06 11:41:03 PDT
[2:39pm] <pinkerton> we can give it a try and see how it feels
Comment 10 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-07-06 22:57:09 PDT
Read comment 0 again; it's very clear.  The whole point of having separate buttons (other than preventing a nasty race condition with user clicks when stop "transforms" into reload) is to allow the user to reload at any time, and Reload needs to be enabled 99.9% of the time (except for the bit described in bug 341895) to allow that.
Comment 11 User image Mike Pinkerton (not reading bugmail) 2006-07-07 06:27:33 PDT
right. let's give it a try and see how it works out.
Comment 12 User image Chris Lawson (gone) 2006-07-13 20:02:11 PDT
Oh, and r=me.

cl
Comment 13 User image Mike Pinkerton (not reading bugmail) 2006-07-14 06:11:55 PDT
Comment on attachment 226029 [details] [diff] [review]
Patch

sr=pink
Comment 14 User image Håkan Waara 2006-07-14 06:25:38 PDT
Checked in.

Note You need to log in before you can comment on or make changes to this bug.