304061 - Refresh (reload) button disabled while page is loading

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Samuel Sidler (old account; do not CC)]

While a page is loading, the refresh button is disabled, however, one can 
still "command-R" to refresh the page. This is not the desired behavior since 
the whole point of having the buttons separate is to allow one to refresh 
whilst the page is loading.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Are you sure this isn't just the hovering bug, bug 267403?

Comment 2

[Samuel Sidler (old account; do not CC)]

Yep. I'm saying it's disabled while the page is loading, not when it's finished
loading.

Comment 3

[Samuel Sidler (old account; do not CC)]

Wevah, do you know much about this?

Comment 4

[Wevah (Nate Weaver)]

I think we're just returning NO for -validateToolbarItem: when the page is loading.

Comment 5

[froodian (Ian Leue)]

Attachment: Patch

Comment 6

[Nick Kreeger]

Shouldn't the refresh button *be* disabled when reloading?
Pink what do you think?

Comment 7

[froodian (Ian Leue)]

Why should it be?  As sam says, this is part of the whole point of having two separate buttons, and if it works, why not let people do it?  Plus, the menu item is enabled while the page is loading, so the button certainly should be (or the menu item should be disabled).  I for one often reload while a page is still loading.

Comment 8

[Nick Kreeger]

If this is the path that we want to go down, this should include the change from bug 267403 in BrowserWindowController to update the toolbar when the page had finished loading.

Comment 9

[froodian (Ian Leue)]

[2:39pm] <pinkerton> we can give it a try and see how it feels

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Read comment 0 again; it's very clear.  The whole point of having separate buttons (other than preventing a nasty race condition with user clicks when stop "transforms" into reload) is to allow the user to reload at any time, and Reload needs to be enabled 99.9% of the time (except for the bit described in bug 341895) to allow that.

Comment 11

[Mike Pinkerton (not reading bugmail)]

right. let's give it a try and see how it works out.

Comment 12

[Chris Lawson (gone)]

Oh, and r=me.

cl

Comment 13

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 226029 [details] [diff] [review]
Patch

sr=pink

Comment 14

[Håkan Waara]

Checked in.