Refresh (reload) button disabled while page is loading

VERIFIED FIXED

Status

VERIFIED FIXED
14 years ago
13 years ago

People

(Reporter: samuel.sidler+old, Assigned: froodian)

Tracking

({fixed1.8.1})

Details

Attachments

(1 attachment)

1.34 KB, patch
bugzilla-graveyard
: review+
hwaara
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
While a page is loading, the refresh button is disabled, however, one can 
still "command-R" to refresh the page. This is not the desired behavior since 
the whole point of having the buttons separate is to allow one to refresh 
whilst the page is loading.
Are you sure this isn't just the hovering bug, bug 267403?
Yep. I'm saying it's disabled while the page is loading, not when it's finished
loading.
Summary: Refreh button disabled while page is loading → Refresh button disabled while page is loading
Wevah, do you know much about this?
I think we're just returning NO for -validateToolbarItem: when the page is loading.
(Assignee)

Updated

13 years ago
Summary: Refresh button disabled while page is loading → Refresh (reload) button disabled while page is loading
(Assignee)

Updated

13 years ago
Assignee: mikepinkerton → stridey
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

13 years ago
Posted patch PatchSplinter Review
Attachment #226029 - Flags: review?(mozilla)

Updated

13 years ago
Blocks: 341853
(Assignee)

Updated

13 years ago
Attachment #226029 - Flags: review?(mozilla) → review?(nick.kreeger)

Comment 6

13 years ago
Shouldn't the refresh button *be* disabled when reloading?
Pink what do you think?
(Assignee)

Comment 7

13 years ago
Why should it be?  As sam says, this is part of the whole point of having two separate buttons, and if it works, why not let people do it?  Plus, the menu item is enabled while the page is loading, so the button certainly should be (or the menu item should be disabled).  I for one often reload while a page is still loading.

Comment 8

13 years ago
If this is the path that we want to go down, this should include the change from bug 267403 in BrowserWindowController to update the toolbar when the page had finished loading.
(Assignee)

Comment 9

13 years ago
[2:39pm] <pinkerton> we can give it a try and see how it feels
Read comment 0 again; it's very clear.  The whole point of having separate buttons (other than preventing a nasty race condition with user clicks when stop "transforms" into reload) is to allow the user to reload at any time, and Reload needs to be enabled 99.9% of the time (except for the bit described in bug 341895) to allow that.
right. let's give it a try and see how it works out.

Updated

13 years ago
Attachment #226029 - Flags: superreview?(mikepinkerton)
Attachment #226029 - Flags: review?(nick.kreeger)
Attachment #226029 - Flags: review?(hwaara)
Attachment #226029 - Flags: review+
Oh, and r=me.

cl

Updated

13 years ago
Attachment #226029 - Flags: review?(hwaara) → review+
Comment on attachment 226029 [details] [diff] [review]
Patch

sr=pink
Attachment #226029 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Updated

13 years ago
Whiteboard: [needs checkin[
(Assignee)

Updated

13 years ago
Whiteboard: [needs checkin[ → [needs checkin]

Comment 14

13 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.