305649 - --enable-default-toolkit=cairo-gtk2 requires pango >= 1.8.0

Status: VERIFIED FIXED

(Core Graveyard :: GFX, defect)

Description

[kmike]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050713 SeaMonkey/1.0a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050713 SeaMonkey/1.0a

I've tried to build Linux Seamonkey with --enable-default-toolkit=cairo-gtk2
Apparently it requires --enable-pango (which is ok), but it barfs on Fedora Core
3 with pango-1.6.0:

nsFontMetricsPango.cpp: In member function `nsresult
nsFontMetricsPango::RealizeFont()':
nsFontMetricsPango.cpp:981: error: `pango_font_description_set_absolute_size'
undeclared (first use this function)
nsFontMetricsPango.cpp:981: error: (Each undeclared identifier is reported only
once for each function it appears in.)

pango_font_description_set_absolute_size() appeared only in pango-1.8, which
isn't that widespread yet in the main distros.
Can the requirements be lowered to pango >= 1.6, like the rest of --enable-pango?


Reproducible: Always

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I see this too. I've only got pango 1.6.0 over here.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Possibly; that api was needed so that we could decouple our DPI setting from
pango's sniffing of the X DPI setting.  It isn't possible to do that with pango
pre-1.8.  FC4 at least has 1.8 ;)

We can possibly make this be an optional thing..

Comment 3

[kmike]

I may be totally off base as I don't know the true chain of dependency, but
looks like --enable-default-toolkit=cairo-gtk2 builds
thebes/nsSystemFontsGTK2.cpp, which in turn uses GetXftDPI(). It's under #ifdef
MOZ_ENABLE_XFT though...

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This patch at lets you build and run on Pango 1.6. We'll still "do the right
thing" if Pango 1.8 is available.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Well actually I haven't tested with Pango 1.8, but that's the intent :-)

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 193663 [details] [diff] [review]
fix

I hate that we have to do this, but it'll do for now.. thanks for the quick
patch.

r+sr=vladimir

Comment 7

[Boris Zbarsky [:bzbarsky]]

It looks like that patch landed on August 24.  Is this fixed?

Comment 8

[kmike]

No, it's gotten even worse - cairo-gtk2 requires pango 1.10.0 now:

checking for pango >= 1.1.0... yes
checking _PANGOCHK_CFLAGS... -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  
checking _PANGOCHK_LIBS...  -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0  
checking for pango >= 1.10.0 pangocairo >= 1.10.0... Requested 'pango >= 1.10.0' but version of Pango is 1.6.0

This is on FC3, FC4 isn't better as it has pango 1.8.0.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

No longer the case; we're back to 1999 with 1.6!

Comment 10

[Boris Zbarsky [:bzbarsky]]

Er.. 1999?  1.6 first shipped in FC3, which shipped in November 2004.

Comment 11

[kmike]

Yes, the exact release date of pango-1.6.0 was 13 Sep 2004.