305955 - No keyboard shortcut for "Bookmark All Tabs"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Now that "Bookmark All Tabs" has a separate menuitem (under the bookmarks menu),
there's no keyboard shortcut for this command.

Comment 1

[Asaf Romano (gone)]

Attachment: patch (no l10n impact)

On the trunk, we might want to change the enitity name.

Comment 2

[Asaf Romano (gone)]

(I should point out that it looks like we're not going to fix this on GTK2, for
now).

Comment 3

[Asaf Romano (gone)]

fixed branch & trunk.

Comment 4

[Steffen Wilberg]

Can somebody please do a /s/Shit/Shift/ on branch and trunk?
This reminds me of bug 253693 comment 3 ;-)

Comment 5

[Asaf Romano (gone)]

fixed ;)

Comment 6

[Steffen Wilberg]

browser-sets.inc is affected as well...

Comment 7

[Gervase Markham [:gerv]]

Asaf: so, why is this shortcut not implemented on Linux?

Gerv

Comment 8

[Asaf Romano (gone)]

Gerv: Ctrl+Shift+[A-F] keyboard shortcuts are reserved on GTK2.

Comment 9

[Gervase Markham [:gerv]]

Asaf: that's unfortunate. Can we provide an alternate key?

(BTW, I believe aaronl should be involved in new key assignments, for
accessibility and coordination reasons. CCing him.)

Gerv

Comment 10

[Aaron Leventhal]

(In reply to comment #9)
> Asaf: that's unfortunate. Can we provide an alternate key?
> 
> (BTW, I believe aaronl should be involved in new key assignments, for
> accessibility and coordination reasons. CCing him.)
> 
> Gerv

Is this currently fixed for some platforms and not others, because of the
Ctrl+Shift+A - F issue?

It's not a huge accessibility issue when you have keyboard access to menus.
Alt+B down Enter is not hard to type.

Comment 11

[Asaf Romano (gone)]

> Is this currently fixed for some platforms and not others, because of the
> Ctrl+Shift+A - F issue?
> 
yes.

Comment 12

[Jay Patel [:jay]]

v.fixed in both places with today's builds.

Comment 13

[Gervase Markham [:gerv]]

Aaron: Alt B Down Enter gives you "Manage Bookmarks", not "Bookmark All Tabs".

"Bookmark All Tabs" would be Ctrl-D Tab Tab Tab Space Enter.

Gerv

Comment 14

[Asaf Romano (gone)]

Gerv: You're clearly not using latest builds.