Closed
Bug 309093
Opened 19 years ago
Closed 19 years ago
Next button state isn't updated after going back
Categories
(Firefox :: Migration, defect)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
People
(Reporter: asaf, Assigned: mconnor)
References
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
2.50 KB,
patch
|
asaf
:
review+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
In the migration wizard, the next button state isn't updated after going back. STR: 1. Open the migration wizard, choose one of the options and click Next. 2. Uncheck everything, at this point, the next button becomes disabled 3. Go back. -> The wizard goes back, but the next button isn't re-enabled. This is a regression from bug 307124, sorry for not catching that on review.
| Assignee | ||
Comment 1•19 years ago
|
||
this isn't actually a regression, I can reproduce in 1.0.6 There's still one remaining issue with this sequence, which is that unchecking all, going back, then going forward rechecks everything. This is because 0 == ALL in nsIBrowserProfileMigrator, but its pretty late for an API change here, but I'll fix that as a followup patch for trunk only. http://lxr.mozilla.org/mozilla/source/browser/components/migration/public/nsIBrowserProfileMigrator.idl#48
Attachment #196605 -
Flags: review?(bugs.mano)
| Reporter | ||
Comment 2•19 years ago
|
||
Comment on attachment 196605 [details] [diff] [review] fix Please get rid of the whitespcae in the line above onImportItemsPageRewound. r=mano
Attachment #196605 -
Flags: review?(bugs.mano) → review+
| Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 196605 [details] [diff] [review] fix low-risk polish fix for wizard bustedness
Attachment #196605 -
Flags: approval1.8b5?
| Assignee | ||
Comment 4•19 years ago
|
||
filed bug Bug 309883 on comment 1
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Attachment #196605 -
Flags: approval1.8b5? → approval1.8b5+
You need to log in
before you can comment on or make changes to this bug.
Description
•