Closed Bug 309712 Opened 15 years ago Closed 15 years ago
HTML-style comments in the middle of .js file cause part of script to be ignored (treated as XML data)
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20050922 Firefox/1.4 Steps to reproduce: 1. Hover one of the equipment icons in http://www.thottbot.com/index.cgi?p=Aydsnizzeth. Result: Nothing happens. Expected: Info box should appear. Regression from bug 309242, "E4X should be on by default, while preserving the comment hiding hack". Identified by MozillaZine Forum member bizarrojack in http://forums.mozillazine.org/viewtopic.php?t=321123.
I guess we can... (1) Back out bug 309242 and go back to requiring opt-in for E4X. (2) Ask sites that use HTML-style comments in strange ways to change their code. (3) Change the heuristic introduced by bug 309242 to handle this case as the author intended. For example, treat "<!--" as the beginning of XML comment data iff it does not occur at the beginning of a statement. Brendan, is (3) realistic?
Copy of http://i73.thottbot.com/js/wow.js.
Assignee: general → brendan
Comment on attachment 197152 [details] [diff] [review] Use a more conservative heuristic Bah! r=mrbkap
Attachment #197152 - Flags: review?(mrbkap) → review+
OS: MacOS X → All
Priority: -- → P1
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8beta5
Comment on attachment 197152 [details] [diff] [review] Use a more conservative heuristic sr=shaver, though I'll also ping the Thottbot guys to fix their script!
Attachment #197152 - Flags: superreview?(shaver) → superreview+
Fixed on trunk and branch. /be
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
*** Bug 309806 has been marked as a duplicate of this bug. ***
*** Bug 309778 has been marked as a duplicate of this bug. ***
*** Bug 309802 has been marked as a duplicate of this bug. ***
test covered by js1_6/Regress/regress-309242.js
You need to log in before you can comment on or make changes to this bug.