Closed
Bug 312089
Opened 19 years ago
Closed 19 years ago
document Delete key as Back/Shift+Delete as Forward on Mac
Categories
(Firefox Graveyard :: Help Documentation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox1.5
People
(Reporter: steffen.wilberg, Assigned: jwalden+fxhelp)
References
Details
(Keywords: fixed1.8, late-l10n)
Attachments
(1 file, 1 obsolete file)
1.59 KB,
patch
|
steffen.wilberg
:
review+
mscott
:
approval1.8rc1+
|
Details | Diff | Splinter Review |
Bug 220590 made the Delete (a.k.a Backspace) key go back on Mac as well.
Currently trunk only.
Reporter | ||
Comment 1•19 years ago
|
||
Now it's checked in on the branch as well.
Keywords: late-l10n
Target Milestone: --- → Firefox1.5
Assignee | ||
Comment 2•19 years ago
|
||
As the shortcut works on all platforms, I see no reason not to move it outside
the platform-specific parts entirely. If you disagree, say so and we can
decide what we want to do instead.
Assignee: nobody → jwalden+fxhelp
Status: NEW → ASSIGNED
Attachment #199615 -
Flags: review?(steffen.wilberg)
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 199615 [details] [diff] [review]
Patch
D'oh, it's Delete and not Backspace. Respinning...
Attachment #199615 -
Attachment is obsolete: true
Attachment #199615 -
Flags: review?(steffen.wilberg)
Assignee | ||
Comment 4•19 years ago
|
||
Attachment #199618 -
Flags: review?(steffen.wilberg)
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 199618 [details] [diff] [review]
Use Del, not Backspace
> <span class="unix">
> &altKey;+<kbd>Right Arrow</kbd><br/>
>- &shiftKey;+<kbd>Backspace</kbd>
>+ &shiftKey;+<kbd>Backspace</kbd><br/>
> &accelKey;+<kbd>]</kbd>
> </span>
Ouch, thanks for catching this!
r=me.
Attachment #199618 -
Flags: review?(steffen.wilberg)
Attachment #199618 -
Flags: review+
Attachment #199618 -
Flags: approval1.8rc1?
Reporter | ||
Comment 6•19 years ago
|
||
Actually, I think that key, which is Backspace on other platforms, is called
"Delete". "Del" is the Delete key on other platforms.
Comment 7•19 years ago
|
||
Steffen's right. On pure Mac keyboards, the key in question is traditionally
labeled "delete", spelled out in full.
Comment 8•19 years ago
|
||
Comment on attachment 199618 [details] [diff] [review]
Use Del, not Backspace
Looks like we need a new patch here. Please request approval when you've got
that. Thanks.
Attachment #199618 -
Flags: approval1.8rc1? → approval1.8rc1-
Reporter | ||
Comment 9•19 years ago
|
||
Comment on attachment 199618 [details] [diff] [review]
Use Del, not Backspace
> Looks like we need a new patch here.
Nah, the person who checks this in merely needs to add "ete" after "Del" here:
>+ <kbd>Del</kbd>
>+ &shiftKey;+<kbd>Del</kbd>
That's it. Rerequesting approval.
Attachment #199618 -
Flags: approval1.8rc1- → approval1.8rc1?
Comment 10•19 years ago
|
||
Comment on attachment 199618 [details] [diff] [review]
Use Del, not Backspace
just don't forget to add the "ete".
Attachment #199618 -
Flags: approval1.8rc1? → approval1.8rc1+
Assignee | ||
Comment 11•19 years ago
|
||
(In reply to comment #10)
> just don't forget to add the "ete".
I didn't.
Patch checked in on branch and trunk; post to n.p.m.l10n forthcoming.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Summary: document Delete key as Back shortcut on Mac → document Delete key as Back/Shift+Delete as Forward on Mac
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•