312560 - Make UI strings in nsSidebar.js localizable

Status: NEW

(SeaMonkey :: Sidebar, defect)

Description

[O. Atsushi (Torisugari)]

There's some l10n problems in nsSidebar.js
http://lxr.mozilla.org/mozilla/source/xpfe/components/sidebar/src/nsSidebar.jshttp://lxr.mozilla.org/mozilla/source/xpfe/components/sidebar/src/nsSidebar.js


1. Hardcoded UI string.
> 283         this.promptService.alert(null, "Failed to add the search engine.");

2. getting stringbundle from chrome://branding/locale/brand.properties
> 290         var brandStringBundle =
srGetStrBundle("chrome://branding/locale/brand.properties");
> 291         if (stringBundle) {
> 292             sidebarName = brandStringBundle.GetStringFromName("sidebarName");

And we glab only one string: "Sidebar". I don't think there's any relationship
between branding and sidebar.


3. We should use formatStringFromName(...) instead of regexp replace(...).

> 294             dialogMessage =
stringBundle.GetStringFromName("addEngineConfirmMessage");
> 295             dialogMessage = dialogMessage.replace(/%title%/, suggestedTitle);
> 296             dialogMessage = dialogMessage.replace(/%category%/,
suggestedCategory);
> 297             dialogMessage = dialogMessage.replace(/%url%/, engineURL);
> 298             dialogMessage = dialogMessage.replace(/#/g, "\n");
> 299             dialogMessage = dialogMessage.replace(/%name%/, sidebarName);

Comment 1

[:Gavin Sharp [email: [e-mail]]]

#1 also has the problem described at bug 268370.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I filed bug 338989 for Firefox.

Comment 3

[Robert Kaiser]

(In reply to comment #0)
> I don't think there's any relationship
> between branding and sidebar.

There was, as Netscape called it "My Sidebar", which was a "branding" difference between Mozilla and Netscape...

Even if I'd really love to have better L12y, we won't block a release for this, and also no Alpha.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

When this is fixed, please make sure we don't use OK/Cancel where we ask a yes/no question.