268370 - missing argument when failing to add a search engine

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Valentijn Sessink]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2

This function seems to miss an argument. When I tried to add a search engine
from a local file (which is, afaics from the source code, illegal), nothing
happens. The Javascript console spews an error: "Not enough arguments
[nslPromptService.alert]"

That is correct, we need an extra argument here.


Reproducible: Always
Steps to Reproduce:
1. add a search engine .src file that is located on the local file system, i.e.
starts with file:///..... instead of http://...../...
Actual Results:  
Nothing. However, the Javascript Console showed 2 error messages

Expected Results:  
show a dialog that says something like "Could not add this search bar, because
$reason"

Comment 1

[Valentijn Sessink]

Attachment: Working fix

I think that actually, the dialog box should tell why the search engine could
not be added. I'm not sure how to do that (should be trivial I think, but I
don't know if it's possible to pick up the Debug results so I didn't try).
Anyway, the attached file makes the dialog box work.

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: minimal fix (for the 1.8.0 branch)

In case this is wanted for the 1.8.0 branch. I don't think alerting here is the right thing to do, I've attached a better general patch in bug 338989.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

This is as far as I know the only known case of bug 267645, which was recently posted to secunia. May want to take the minimal fix on the 1.8.0 branch.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: minimal fix v2 (for the 1.8.0 branch)

Fixes bug 267645 comment 2 also.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 224811 [details] [diff] [review]
minimal fix v2 (for the 1.8.0 branch)

This fixes two of the easier-to-hit cases of bug 267645.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 224811 [details] [diff] [review]
minimal fix v2 (for the 1.8.0 branch)

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sidebar/src/nsSidebar.js 	1.10.14.2

This patch doesn't need to go in anywhere else, since bug 338989 had a better fix for 1.8 and trunk.

Comment 10

[Daniel Veditz [:dveditz]]

Since Product==Firefox bugs don't have appropriate SeaMonkey release flags I filed bug 342205 on the Suite and attached a merged version of attachment 224811 [details] [diff] [review]

Comment 11

[Adam Guthrie]

Verified FIXED using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060621 Firefox/1.5.0.5.

No more appdir-exposing adding a search engine fails (because of bad URL, etc.).

Comment 12

[Adam Guthrie]

Err... above comment should read "no more appdir-exposing error message when adding a search engine fails".