Closed Bug 338989 Opened 19 years ago Closed 19 years ago

Make nsSidebar strings localizable

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Version:
2.0 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta1

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Keywords: fixed1.8.1, l12y)

Attachments

(1 file, 1 obsolete file)

change entities too
7.89 KB, patch
Details | Diff | Splinter Review
This is the Firefox version of xpfe bug 312560.
Attached patch patch (obsolete) — — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #223038 - Flags: review?(mconnor)
Priority: -- → P1
Target Milestone: --- → Firefox 2 beta1
Flags: blocking-firefox2?
Whiteboard: [patch-r+]
Whiteboard: [patch-r+] → [patch-r?]
Flags: blocking-firefox2? → blocking-firefox2+
Comment on attachment 223038 [details] [diff] [review] patch Ok, but the property names need to get revved so localizers who are caught up will pick up that change.
Attachment #223038 - Flags: review?(mconnor)
Attachment #223038 - Flags: review+
Attachment #223038 - Flags: approval-branch-1.8.1+
Whiteboard: [patch-r?] → [checkin needed]
Attachment #223038 - Attachment is obsolete: true
mozilla/browser/locales/en-US/chrome/browser/sidebar/sidebar.properties 1.5 mozilla/browser/components/sidebar/src/nsSidebar.js 1.15 mozilla/browser/locales/en-US/chrome/browser/sidebar/sidebar.properties 1.2.22.3 mozilla/browser/components/sidebar/src/nsSidebar.js 1.10.8.5
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
If the engine-add fails because of a bad engineURL or iconURL, the user who clicked the link gets no feedback at all. That tends to make it look like FF is broken, rather than like the web page is broken.
Comment #5 filed as bug 341437
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: