312598 - Duplicated thread in threaded view of virtual folder and quick search

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[u69748]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051015 Firefox/1.4.1
Build Identifier: version 1.5 Beta 2 (20051015)

I see Duplicated thread in threaded virtual folder.

Ex.
+ message1
  + message1-1
  + message1-2
+ message1
  + message1-1
  + message1-2


Reproducible: Always

Steps to Reproduce:

Comment 1

[u69748]

Attachment: screen shot

This virtual folder is created form Inbox.
See Order Received column.

Comment 2

[Adam Guthrie]

This looks exactly like the screenshot in bug 270873. See also bug 178999, bug
194444, and bug 154403.

Comment 3

[u69748]

I can see same problem in threaded view of quick search in Inbox.

Note: Compact folder and rebuilding .msf did not solve this problem.

Comment 4

[u69748]

Attachment: another screen shot

At least, most threads are duplicated in virtual folder.

Comment 5

[David :Bienvenu]

must be a problem in the code that detects if a thread is already in the view...

Comment 6

[David :Bienvenu]

Attachment: proposed fix

the problem came about because I removed the check that we were sorting by Id
to fix some other problem. But the code that builds up the list of root threads
assumed we were sorting by ID, since it did a binary search on the thread ids,
based on sort order. So the fix is to make sure the initial thread roots are
sorted by id, and then if the requested sort is not by ID, sort the thread
roots afterwards, before expanding them.

I was only able to recreate this problem by going into threaded mode in a quick
search view, and then using the view | sort by subject/sender, etc menu item to
sort the top level threads.